gh-107932: Fix dis module for bytecode that does not have an associated source line #107988
Conversation
|
All commit authors signed the Contributor License Agreement. |
|
Most changes to Python require a NEWS entry. Please add it using the blurb_it web app or the blurb command-line tool. |
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
|
@markshannon Thanks for the quick review! I have made the requested changes; please review again. I have also updated the docs to reflect the changes and resolved the merge conflict (for now). I've listed the changes in the docs as happening in 3.13 (is this the correct procedure for the project?) |
|
Thanks for making the requested changes! @markshannon: please review the changes made to this pull request. |
|
|
Fix dis module for bytecode that does not have an associated source line.
fixes #107932
This does change behavior of many of the dis.py public functions to display lines with no source line mapping as such.
At the very least it changes:
findlinestarts - now returns starts of bytecode blocks that dont have a source line with lineno=None
dis/disassemble/distb/disco - now separates and labels lineno=None bytecode blocks, previously it lumped them into the previous block (see #107932)
get_instructions & Instruction - Instruction objects now have starts_line=False to indicate that the instruction does not start a line.
dis.dis()reports line numbers where there are none. #107932