-
-
Notifications
You must be signed in to change notification settings - Fork 31.9k
Remove Sphinx problem matcher to avoid annotating unchanged files #108005
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+0
−44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serhiy-storchaka
approved these changes
Aug 16, 2023
AlexWaygood
approved these changes
Aug 16, 2023
AA-Turner
approved these changes
Aug 16, 2023
Thanks @hugovk for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
GH-108049 is a backport of this pull request to the 3.12 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 16, 2023
…thonGH-108005) (cherry picked from commit 0d7f5d3) Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
GH-108050 is a backport of this pull request to the 3.11 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 16, 2023
…thonGH-108005) (cherry picked from commit 0d7f5d3) Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
Yhg1s
pushed a commit
that referenced
this pull request
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In PRs like https://github.com/python/cpython/pull/107986/files, we're getting annotations for files which haven't been changed by the PR (see "Unchanged files with check annotations"), which is distracting.
Let's remove them.
Originally added in:
(Note this retains the annotations added by
Doc/tools/check-warnings.py
, because they're only added to files you modified in your PR.)