Skip to content

Remove Sphinx problem matcher to avoid annotating unchanged files #108005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 16, 2023

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Aug 16, 2023

In PRs like https://github.com/python/cpython/pull/107986/files, we're getting annotations for files which haven't been changed by the PR (see "Unchanged files with check annotations"), which is distracting.

Let's remove them.

Originally added in:

(Note this retains the annotations added by Doc/tools/check-warnings.py, because they're only added to files you modified in your PR.)

@hugovk hugovk merged commit 0d7f5d3 into python:main Aug 16, 2023
@hugovk hugovk deleted the docs-rm-problem-matcher branch August 16, 2023 18:18
@miss-islington
Copy link
Contributor

Thanks @hugovk for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-108049 is a backport of this pull request to the 3.12 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label Aug 16, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 16, 2023
…thonGH-108005)

(cherry picked from commit 0d7f5d3)

Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
@bedevere-bot
Copy link

GH-108050 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Aug 16, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 16, 2023
…thonGH-108005)

(cherry picked from commit 0d7f5d3)

Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
hugovk added a commit that referenced this pull request Aug 16, 2023
…les (GH-108005) (#108050)

Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
Yhg1s pushed a commit that referenced this pull request Aug 16, 2023
…les (GH-108005) (#108049)

Remove Sphinx problem matcher to avoid annotating unchanged files (GH-108005)
(cherry picked from commit 0d7f5d3)

Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants