Skip to content

GH-92584: Remove Installing Python Modules (Distutils version) #108020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 16, 2023
Merged

GH-92584: Remove Installing Python Modules (Distutils version) #108020

merged 5 commits into from
Aug 16, 2023

Conversation

AA-Turner
Copy link
Member

@AA-Turner AA-Turner commented Aug 16, 2023 •
edited by github-actions bot
Loading

This removes install/index, per the notice in the header:

The entire distutils package has been deprecated and will be removed in Python 3.12. This documentation is retained as a reference only, and will be removed with the package.

See #108018 to retain the install scheme content in the sysconfig docs.

A

📚 Documentation preview 📚: https://cpython-previews--108020.org.readthedocs.build/

@AA-Turner AA-Turner added docs Documentation in the Doc dir skip news needs backport to 3.12 only security fixes labels Aug 16, 2023
@AA-Turner AA-Turner requested review from vstinner and zooba August 16, 2023 13:24
@bedevere-bot bedevere-bot mentioned this pull request Aug 16, 2023
Closed
@vstinner
Copy link
Member

The doc fails to build:

Doc/library/site.rst:188: WARNING: undefined label: inst-alt-install-user (if the link has no caption the label must precede a section header)
Doc/using/cmdline.rst:812: WARNING: undefined label: inst-alt-install-user (if the link has no caption the label must precede a section header)

vstinner
vstinner approved these changes Aug 16, 2023
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AA-Turner
Copy link
Member Author

@vstinner thanks, I've removed the references so the build succeeds, #108018 will restore them.

A

vstinner
vstinner reviewed Aug 16, 2023
View reviewed changes
Doc/using/cmdline.rst Outdated
@@ -811,7 +811,7 @@ conflict.

Defines the :data:`user base directory <site.USER_BASE>`, which is used to
compute the path of the :data:`user site-packages directory <site.USER_SITE>`
and :ref:`Distutils installation paths <inst-alt-install-user>` for
and Distutils installation paths for
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it really useful to keep a reference to removed Distutils? setup.py is legacy, no?

Copy link
Member Author

@AA-Turner AA-Turner Aug 16, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#108040 removes the reference to Distutils & replaces setup.py with pip, I wanted to keep each PR distinct. When the first one is merged I'll resolve the conflicts.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conflicts resolved.

@AA-Turner
Merge branch 'main' into drop-install
df3ce4f 
# Conflicts:
#	Doc/using/cmdline.rst
@vstinner
Copy link
Member

A Docs job failed:

Doc/using/cmdline.rst:812: WARNING: undefined label: inst-alt-install-user (if the link has no caption the label must precede a section header)

@AA-Turner
Copy link
Member Author

A Docs job failed:

Oh, I messed up the merge. Pushed a fix.

@vstinner vstinner enabled auto-merge (squash) August 16, 2023 21:03
@vstinner vstinner merged commit fbb7cbc into python:main Aug 16, 2023
@miss-islington
Copy link
Contributor

Thanks @AA-Turner for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @AA-Turner and @vstinner, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker fbb7cbc0e92168077fd56de942901511e99ca60a 3.12

@bedevere-bot
Copy link

GH-108062 is a backport of this pull request to the 3.12 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label Aug 16, 2023
AA-Turner added a commit to AA-Turner/cpython that referenced this pull request Aug 16, 2023
@AA-Turner
[3.12] pythonGH-92584: Remove Installing Python Modules (Distutils ve…
67df3e3 
…rsion) (pythonGH-108020).

(cherry picked from commit fbb7cbc)

Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Yhg1s pushed a commit that referenced this pull request Aug 17, 2023
@AA-Turner
[3.12] GH-92584: Remove Installing Python Modules (Distutils version) (…
560e859 
…GH-108020) (#108062)

* [3.12] GH-92584: Remove Installing Python Modules (Distutils version) (GH-108020).
(cherry picked from commit fbb7cbc)

Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

@zooba zooba Awaiting requested review from zooba

Assignees

@vstinner vstinner

Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AA-Turner @vstinner @miss-islington @bedevere-bot