-
-
Notifications
You must be signed in to change notification settings - Fork 31.8k
GH-92584: Remove references to Distutils in configure.rst #108043
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -686,7 +686,6 @@ Main files of the build system | |
* :file:`pyconfig.h` (created by :file:`configure`); | ||
* :file:`Modules/Setup`: C extensions built by the Makefile using | ||
:file:`Module/makesetup` shell script; | ||
* :file:`setup.py`: C extensions built using the ``setuptools`` package. | ||
|
||
Main build steps | ||
---------------- | ||
|
@@ -695,8 +694,7 @@ Main build steps | |
* A static ``libpython`` library (``.a``) is created from objects files. | ||
* ``python.o`` and the static ``libpython`` library are linked into the | ||
final ``python`` program. | ||
* C extensions are built by the Makefile (see :file:`Modules/Setup`) | ||
and ``python setup.py build``. | ||
* C extensions are built by the Makefile (see :file:`Modules/Setup`). | ||
|
||
Main Makefile targets | ||
--------------------- | ||
|
@@ -748,9 +746,6 @@ Example on Linux x86-64:: | |
At the beginning of the files, C extensions are built as built-in modules. | ||
Extensions defined after the ``*shared*`` marker are built as dynamic libraries. | ||
|
||
The :file:`setup.py` script only builds C extensions as shared libraries using | ||
the :mod:`distutils` module. | ||
|
||
The :c:macro:`PyAPI_FUNC()`, :c:macro:`PyAPI_API()` and | ||
:c:macro:`PyMODINIT_FUNC()` macros of :file:`Include/pyport.h` are defined | ||
differently depending if the ``Py_BUILD_CORE_MODULE`` macro is defined: | ||
|
@@ -784,7 +779,7 @@ Preprocessor flags | |
headers in a nonstandard directory ``<include dir>``. | ||
|
||
Both :envvar:`CPPFLAGS` and :envvar:`LDFLAGS` need to contain the shell's | ||
value for setup.py to be able to build extension modules using the | ||
value to be able to build extension modules using the | ||
directories specified in the environment variables. | ||
|
||
.. envvar:: BASECPPFLAGS | ||
|
@@ -821,8 +816,8 @@ Compiler flags | |
.. envvar:: CFLAGS_NODIST | ||
|
||
:envvar:`CFLAGS_NODIST` is used for building the interpreter and stdlib C | ||
extensions. Use it when a compiler flag should *not* be part of the | ||
distutils :envvar:`CFLAGS` once Python is installed (:issue:`21121`). | ||
extensions. Use it when a compiler flag should *not* be part of | ||
:envvar:`CFLAGS` once Python is installed (:gh:`65320`). | ||
Comment on lines
+819
to
+820
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm not sure if the issue link (#65320) is still relevant, but I've kept in case. |
||
|
||
In particular, :envvar:`CFLAGS` should not contain: | ||
|
||
|
@@ -952,7 +947,7 @@ Linker flags | |
|
||
:envvar:`LDFLAGS_NODIST` is used in the same manner as | ||
:envvar:`CFLAGS_NODIST`. Use it when a linker flag should *not* be part of | ||
the distutils :envvar:`LDFLAGS` once Python is installed (:issue:`35257`). | ||
:envvar:`LDFLAGS` once Python is installed (:gh:`65320`). | ||
|
||
In particular, :envvar:`LDFLAGS` should not contain: | ||
|
||
|
@@ -974,7 +969,7 @@ Linker flags | |
directory ``<lib dir>``. | ||
|
||
Both :envvar:`CPPFLAGS` and :envvar:`LDFLAGS` need to contain the shell's | ||
value for setup.py to be able to build extension modules using the | ||
value to be able to build extension modules using the | ||
directories specified in the environment variables. | ||
|
||
.. envvar:: LIBS | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've just removed
setup.py
rather than replacing with e.g.Makefile
as I believe CPPFLAGS and LDFLAGS are used by the windows build, though I'm not sure.