Skip to content

gh-85283: _scproxy uses the limited C API #108572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

gh-85283: _scproxy uses the limited C API #108572

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d2d784b
gh-85283: _scproxy uses the limited C API
vstinner Aug 26, 2023
dbc373a
Replace Py_SETREF(v, NULL) with Py_CLEAR(v)
vstinner Aug 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Misc/NEWS.d/next/C API/2023-08-28-17-58-46.gh-issue-85283.-4lp73.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
The ``_scproxy`` (macOS) C extension is now built with the :ref:`limited C API
<limited-c-api>`. Patch by Victor Stinner.
4 changes: 3 additions & 1 deletion Modules/_scproxy.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@
* Helper method for urllib to fetch the proxy configuration settings
* using the SystemConfiguration framework.
*/
#define Py_LIMITED_API 0x030d0000

#include <Python.h>
#include <SystemConfiguration/SystemConfiguration.h>

Expand Down Expand Up @@ -84,7 +86,7 @@ get_proxy_settings(PyObject* Py_UNUSED(mod), PyObject *Py_UNUSED(ignored))
if (v == NULL) goto error;

r = PyDict_SetItemString(result, "exclude_simple", v);
Py_SETREF(v, NULL);
Py_CLEAR(v);
if (r == -1) goto error;

anArray = CFDictionaryGetValue(proxyDict,
Expand Down