bpo-9004: Recommend against using utctimetuple in the docs. #10870
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes issue 9004. Original patch by Gaurav Tatke.
|
@abalkin please add a news entry. You can use https://blurb-it.herokuapp.com/ to do this. |
| @@ -742,6 +742,8 @@ Other constructors, all class methods: | |||
| If *tz* is not ``None``, it must be an instance of a :class:`tzinfo` subclass, and the | |||
| current date and time are converted to *tz*’s time zone. In this case the | |||
| result is equivalent to ``tz.fromutc(datetime.utcnow().replace(tzinfo=tz))``. | |||
| It is recommended to create aware datetime object for current UTC time by | |||
There was a problem hiding this comment.
Am not a native english speaker but shouldn't this "It is recommended to create aware datetime object " be "It is recommended to create an aware datetime object for current" or "be "It is recommended to create aware datetime objects for current"
There was a problem hiding this comment.
Am not a native english speaker neither but I'd propose:
The recommended way to create aware datetime object for the current time in UTC is ...
|
cc @pganssle |
|
I think maybe we should consolidate this into #15773. @nanjekyejoannah Do you mind adding a similar warning box to |
|
Closed in favor of #15773 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes bpo-9004.
Original patch by Gaurav Tatke.
https://bugs.python.org/issue9004