Skip to content

gh-91539: Small performance improvement of urrlib.request.getproxies_environment() #108771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jan 15, 2024
Merged

gh-91539: Small performance improvement of urrlib.request.getproxies_environment() #108771

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
b1d155f
Small performance improvement of getproxies_environment() when there …
RaphaelMarinier Sep 1, 2023
0e43950
📜🤖 Added by blurb_it.
blurb-it[bot] Sep 1, 2023
54e48bf
Merge branch 'main' into speedup-getproxies-environment
RaphaelMarinier Sep 1, 2023
74f8537
Update Misc/NEWS.d/next/Library/2023-09-01-15-33-18.gh-issue-91539.xo…
hauntsaninja Sep 18, 2023
f93f749
Merge branch 'main' into speedup-getproxies-environment
RaphaelMarinier Sep 18, 2023
53caf76
Merge branch 'main' into speedup-getproxies-environment
RaphaelMarinier Sep 24, 2023
0b57f48
Merge branch 'main' into speedup-getproxies-environment
hauntsaninja Oct 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Lib/urllib/request.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2490,7 +2490,7 @@ def getproxies_environment():
# select only environment variables which end in (after making lowercase) _proxy
proxies = {}
environment = []
for name in os.environ.keys():
for name in os.environ:
# fast screen underscore position before more expensive case-folding
if len(name) > 5 and name[-6] == "_" and name[-5:].lower() == "proxy":
value = os.environ[name]
Expand Down
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Library/2023-09-01-15-33-18.gh-issue-91539.xoNLEI.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Small (10 - 20%) and trivial performance improvement of :func:`urrlib.request.getproxies_environment`, typically useful when there are many environment variables to go over.