-
-
Notifications
You must be signed in to change notification settings - Fork 31.8k
gh-108777: Split _PyTime tests from _testinternalcapi.c #108787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Nice change. |
|
Do you have any objections on backporting this PR? Because next PRs like #110630 are impossible to backport :( |
Sure, the change can be backported. Do you want to backport it to 3.12 and 3.11? |
I am not sure about the CAPI semantics, but the test structure would be nice to have in both 3.11 and 3.12 |
Thanks @colesbury for the PR, and @corona10 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12. |
Sorry, @colesbury and @corona10, I could not cleanly backport this to
|
This moves the 12
_PyTime
related tests to their own file inModules/_testinternalcapi/
.