Documentation: XML Element - pi objects instead of comment objects #108848
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
update regarding second commit : docstring and source code say it's a process instruction |
| @@ -661,7 +661,7 @@ Functions | |||
| given. Returns an element instance, representing a processing instruction. | |||
|
|
|||
| Note that :class:`XMLParser` skips over processing instructions | |||
| in the input instead of creating comment objects for them. An | |||
| in the input instead of creating pi objects for them. An | |||
There was a problem hiding this comment.
Is it clear? Maybe use "processing instruction objects"?
|
Thanks @christopheNan for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 1, 2024
PI objects instead of comment objects. (cherry picked from commit de6f97c) Co-authored-by: Christophe Nanteuil <35002064+christopheNan@users.noreply.github.com>
|
GH-114854 is a backport of this pull request to the 3.12 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 1, 2024
PI objects instead of comment objects. (cherry picked from commit de6f97c) Co-authored-by: Christophe Nanteuil <35002064+christopheNan@users.noreply.github.com>
|
GH-114855 is a backport of this pull request to the 3.11 branch. |
serhiy-storchaka
pushed a commit
that referenced
this pull request
Feb 1, 2024
serhiy-storchaka
pushed a commit
that referenced
this pull request
Feb 1, 2024
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
PI objects instead of comment objects.
JulienPalard
pushed a commit
to python/python-docs-fr
that referenced
this pull request
Mar 23, 2024
Pour information, la traduction m'a amené à créer cette [PR](python/cpython#108848) dans CPython. Reviewed-on: https://git.afpy.org/AFPy/python-docs-fr/pulls/187 Reviewed-by: Julien Palard <julien@palard.fr> Co-authored-by: Christophe Nanteuil <christophe.nanteuil@gmail.com> Co-committed-by: Christophe Nanteuil <christophe.nanteuil@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While translating the XML documentation in French, I noticed that this would better describe the mechanism of parsing.
📚 Documentation preview 📚: https://cpython-previews--108848.org.readthedocs.build/