Skip to content

gh-89392: Remove test_main() in test_netrc #108860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 4, 2023
Merged

gh-89392: Remove test_main() in test_netrc #108860

merged 1 commit into from
Sep 4, 2023

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Sep 4, 2023 •
edited by bedevere-bot
Loading

@serhiy-storchaka serhiy-storchaka added tests Tests in the Lib/test dir skip news needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Sep 4, 2023
@bedevere-bot bedevere-bot mentioned this pull request Sep 4, 2023
Closed
@serhiy-storchaka serhiy-storchaka merged commit 76f3c04 into python:main Sep 4, 2023
@miss-islington
Copy link
Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@serhiy-storchaka serhiy-storchaka deleted the test_netrc-test_main branch September 4, 2023 09:41
@miss-islington
Copy link
Contributor

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 76f3c043b6c5971d5a13fc6decf87a80ddf7ef95 3.12

@bedevere-bot
Copy link

GH-108868 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Sep 4, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 4, 2023
@serhiy-storchaka @miss-islington
pythongh-89392: Remove test_main() in test_netrc (pythonGH-108860)
4f5eed6 
(cherry picked from commit 76f3c04)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Sep 4, 2023
@serhiy-storchaka
[3.12] pythongh-89392: Remove test_main() in test_netrc (pythonGH-108860
96be51b 
).

(cherry picked from commit 76f3c04)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-bot
Copy link

GH-108872 is a backport of this pull request to the 3.12 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label Sep 4, 2023
serhiy-storchaka added a commit that referenced this pull request Sep 4, 2023
@miss-islington @serhiy-storchaka
[3.11] gh-89392: Remove test_main() in test_netrc (GH-108860) (GH-108868
723ca8c 
)

(cherry picked from commit 76f3c04)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@serhiy-storchaka serhiy-storchaka removed their assignment Sep 4, 2023
Yhg1s added a commit that referenced this pull request Sep 4, 2023
@serhiy-storchaka @Yhg1s
[3.12] gh-89392: Remove test_main() in test_netrc (GH-108860) (#108872)
88ff02e 
[3.12] gh-89392: Remove test_main() in test_netrc (GH-108860).
(cherry picked from commit 76f3c04)

Co-authored-by: T. Wouters <thomas@python.org>
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Windows10 3.12 has failed when building commit 88ff02e.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/1159/builds/304) and take a look at the build logs.
  4. Check if the failure is related to this commit (88ff02e) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/1159/builds/304

Failed tests:

  • test.test_concurrent_futures.test_shutdown
  • test.test_concurrent_futures.test_process_pool

Failed subtests:

  • test_map_timeout - test.test_concurrent_futures.test_process_pool.ProcessPoolSpawnProcessPoolExecutorTest.test_map_timeout

Summary of the results of the build (if available):

==

Click to see traceback logs 
Traceback (most recent call last):
  File "D:\buildarea\3.12.bolen-windows10\build\Lib\test\support\os_helper.py", line 480, in temp_dir
    yield path
  File "D:\buildarea\3.12.bolen-windows10\build\Lib\test\support\os_helper.py", line 533, in temp_cwd
    yield cwd_dir
  File "D:\buildarea\3.12.bolen-windows10\build\Lib\test\libregrtest\main.py", line 795, in main
    self._main(tests, kwargs)
  File "D:\buildarea\3.12.bolen-windows10\build\Lib\test\libregrtest\main.py", line 854, in _main
    sys.exit(0)
SystemExit: 0


Traceback (most recent call last):
  File "D:\buildarea\3.12.bolen-windows10\build\Lib\test\test_concurrent_futures\executor.py", line 68, in test_map_timeout
    self.assertEqual([None, None], results)
AssertionError: Lists differ: [None, None] != []


Traceback (most recent call last):
  File "D:\buildarea\3.12.bolen-windows10\build\Lib\runpy.py", line 198, in _run_module_as_main
    return _run_code(code, main_globals, None,
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "D:\buildarea\3.12.bolen-windows10\build\Lib\runpy.py", line 88, in _run_code
    exec(code, run_globals)
  File "D:\buildarea\3.12.bolen-windows10\build\Lib\test\__main__.py", line 2, in <module>
    main()
  File "D:\buildarea\3.12.bolen-windows10\build\Lib\test\libregrtest\main.py", line 859, in main
    Regrtest().main(tests=tests, **kwargs)
  File "D:\buildarea\3.12.bolen-windows10\build\Lib\test\libregrtest\main.py", line 789, in main
    with os_helper.temp_cwd(test_cwd, quiet=True):
  File "D:\buildarea\3.12.bolen-windows10\build\Lib\contextlib.py", line 155, in __exit__
    self.gen.throw(value)
  File "D:\buildarea\3.12.bolen-windows10\build\Lib\test\support\os_helper.py", line 531, in temp_cwd
    with temp_dir(path=name, quiet=quiet) as temp_path:
  File "D:\buildarea\3.12.bolen-windows10\build\Lib\contextlib.py", line 155, in __exit__
    self.gen.throw(value)
  File "D:\buildarea\3.12.bolen-windows10\build\Lib\test\support\os_helper.py", line 485, in temp_dir
    rmtree(path)
  File "D:\buildarea\3.12.bolen-windows10\build\Lib\test\support\os_helper.py", line 442, in rmtree
    _rmtree(path)
  File "D:\buildarea\3.12.bolen-windows10\build\Lib\test\support\os_helper.py", line 385, in _rmtree
    _waitfor(_rmtree_inner, path, waitall=True)
  File "D:\buildarea\3.12.bolen-windows10\build\Lib\test\support\os_helper.py", line 330, in _waitfor
    func(pathname)
  File "D:\buildarea\3.12.bolen-windows10\build\Lib\test\support\os_helper.py", line 382, in _rmtree_inner
    _force_run(fullname, os.rmdir, fullname)
  File "D:\buildarea\3.12.bolen-windows10\build\Lib\test\support\__init__.py", line 218, in _force_run
    return func(*args)
           ^^^^^^^^^^^
PermissionError: [WinError 32] The process cannot access the file because it is being used by another process: 'D:\\buildarea\\3.12.bolen-windows10\\build\\build\\test_python_2696�\\test_python_worker_5284�'


Traceback (most recent call last):
  File "D:\buildarea\3.12.bolen-windows10\build\Lib\test\support\__init__.py", line 207, in _force_run
    return func(*args)
           ^^^^^^^^^^^
PermissionError: [WinError 32] The process cannot access the file because it is being used by another process: 'D:\\buildarea\\3.12.bolen-windows10\\build\\build\\test_python_2696�\\test_python_worker_5284�'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@serhiy-storchaka @miss-islington @bedevere-bot