Skip to content

gh-108962: Skip test_tempfile.test_flags() if not supported #108964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 5, 2023
Merged

gh-108962: Skip test_tempfile.test_flags() if not supported #108964

merged 3 commits into from
Sep 5, 2023

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Sep 5, 2023 •
edited by bedevere-bot
Loading

Skip test_tempfile.test_flags() if chflags() fails with "OSError: [Errno 45] Operation not supported" (ex: on FreeBSD 13).

@vstinner
pythongh-108962: Skip test_tempfile.test_flags() if not supported
44b4336 
Skip test_tempfile.test_flags() if chflags() fails with "OSError:
[Errno 45] Operation not supported" (ex: on FreeBSD 13).
@bedevere-bot bedevere-bot added awaiting core review tests Tests in the Lib/test dir labels Sep 5, 2023
@bedevere-bot bedevere-bot mentioned this pull request Sep 5, 2023
Closed
@vstinner
Copy link
Member Author

vstinner commented Sep 5, 2023

@zware tested manually on the buildbot machine and reported to me that this change fix test_tempfile.

I tested manually on my FreeBSD 13: I cannot reproduce #108962 bug, but the test failed when I forgot os.chflags(filename, 0). I fixed my PR and it now pass as well when os.chflags() doesn't fail.

This was referenced Sep 5, 2023
Merged
Merged
@vstinner vstinner enabled auto-merge (squash) September 5, 2023 21:29
@vstinner vstinner merged commit cd2ef21 into python:main Sep 5, 2023
@vstinner vstinner deleted the test_tempfile_flags branch September 5, 2023 21:59
@vstinner vstinner added OS-freebsd needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Sep 5, 2023
@miss-islington
Copy link
Contributor

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington
Copy link
Contributor

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 5, 2023
@vstinner @miss-islington
pythongh-108962: Skip test_tempfile.test_flags() if not supported (py…
ceedcf7 
…thonGH-108964)

Skip test_tempfile.test_flags() if chflags() fails with "OSError:
[Errno 45] Operation not supported" (ex: on FreeBSD 13).
(cherry picked from commit cd2ef21)

Co-authored-by: Victor Stinner <vstinner@python.org>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 5, 2023
@vstinner @miss-islington
pythongh-108962: Skip test_tempfile.test_flags() if not supported (py…
34674c0 
…thonGH-108964)

Skip test_tempfile.test_flags() if chflags() fails with "OSError:
[Errno 45] Operation not supported" (ex: on FreeBSD 13).
(cherry picked from commit cd2ef21)

Co-authored-by: Victor Stinner <vstinner@python.org>
@bedevere-bot
Copy link

GH-108967 is a backport of this pull request to the 3.12 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label Sep 5, 2023
@bedevere-bot
Copy link

GH-108968 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Sep 5, 2023
vstinner added a commit that referenced this pull request Sep 8, 2023
@miss-islington @vstinner
[3.11] gh-108962: Skip test_tempfile.test_flags() if not supported (G…
9dd28d2 
…H-108964) (#108968)

gh-108962: Skip test_tempfile.test_flags() if not supported (GH-108964)

Skip test_tempfile.test_flags() if chflags() fails with "OSError:
[Errno 45] Operation not supported" (ex: on FreeBSD 13).
(cherry picked from commit cd2ef21)

Co-authored-by: Victor Stinner <vstinner@python.org>
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot s390x Fedora LTO + PGO 3.11 has failed when building commit 9dd28d2.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/1023/builds/909) and take a look at the build logs.
  4. Check if the failure is related to this commit (9dd28d2) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/1023/builds/909

Failed tests:

  • test_tools

Summary of the results of the build (if available):

==

Click to see traceback logs 
Traceback (most recent call last):
  File "/home/dje/cpython-buildarea/3.11.edelsohn-fedora-z.lto-pgo/build/Lib/multiprocessing/resource_tracker.py", line 209, in main
    cache[rtype].remove(name)
KeyError: '/psm_544675dc'


Traceback (most recent call last):
  File "/home/dje/cpython-buildarea/3.11.edelsohn-fedora-z.lto-pgo/build/Lib/multiprocessing/resource_tracker.py", line 209, in main
    cache[rtype].remove(name)
KeyError: '/psm_162f758e'


Traceback (most recent call last):
  File "/home/dje/cpython-buildarea/3.11.edelsohn-fedora-z.lto-pgo/build/Lib/multiprocessing/resource_tracker.py", line 209, in main
    cache[rtype].remove(name)
KeyError: '/psm_5e0c1d7a'

Yhg1s pushed a commit that referenced this pull request Sep 8, 2023
@miss-islington @vstinner
[3.12] gh-108962: Skip test_tempfile.test_flags() if not supported (G…
b9dfe60 
…H-108964) (#108967)

gh-108962: Skip test_tempfile.test_flags() if not supported (GH-108964)

Skip test_tempfile.test_flags() if chflags() fails with "OSError:
[Errno 45] Operation not supported" (ex: on FreeBSD 13).
(cherry picked from commit cd2ef21)

Co-authored-by: Victor Stinner <vstinner@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
OS-freebsd tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vstinner @miss-islington @bedevere-bot