Skip to content

gh-109162: Regrtest copies 'ns' attributes #109168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 8, 2023
Merged

gh-109162: Regrtest copies 'ns' attributes #109168

merged 1 commit into from
Sep 8, 2023

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Sep 8, 2023 •
edited by bedevere-bot
Loading

  • Regrtest.init() now copies 'ns' namespace attributes to Regrtest attributes. Regrtest match_tests and ignore_tests attributes have type FilterTuple (tuple), instead of a list.
  • Add RunTests.copy(). Regrtest._rerun_failed_tests() now uses RunTests.copy().
  • Replace Regrtest.all_tests (list) with Regrtest.first_runtests (RunTests).
  • Make random_seed maximum 10x larger (9 digits, instead of 8).

@vstinner
pythongh-109162: Regrtest copies 'ns' attributes
8639d99 
* Regrtest.__init__() now copies 'ns' namespace attributes to
  Regrtest attributes. Regrtest match_tests and ignore_tests
  attributes have type FilterTuple (tuple), instead of a list.
* Add RunTests.copy(). Regrtest._rerun_failed_tests() now uses
  RunTests.copy().
* Replace Regrtest.all_tests (list) with Regrtest.first_runtests
  (RunTests).
* Make random_seed maximum 10x larger (9 digits, instead of 8).
@vstinner vstinner enabled auto-merge (squash) September 8, 2023 22:44
@bedevere-bot bedevere-bot mentioned this pull request Sep 8, 2023
Closed
@vstinner vstinner merged commit ac8409b into python:main Sep 8, 2023
@vstinner vstinner deleted the regrtest_refactor2 branch September 8, 2023 23:48
@vstinner vstinner mentioned this pull request Sep 9, 2023
Merged
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Windows11 Non-Debug 3.x has failed when building commit ac8409b.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/914/builds/2794) and take a look at the build logs.
  4. Check if the failure is related to this commit (ac8409b) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/914/builds/2794

Failed tests:

  • test.test_concurrent_futures.test_deadlock
  • test_msvcrt

Failed subtests:

  • test_kbhit - test.test_msvcrt.TestConsoleIO.test_kbhit
  • test_getwch - test.test_msvcrt.TestConsoleIO.test_getwch

Summary of the results of the build (if available):

==

Click to see traceback logs 
Traceback (most recent call last):
  File "b:\uildarea\3.x.ware-win11.nondebug\build\Lib\test\test_msvcrt.py", line 65, in test_kbhit
    self.assertEqual(msvcrt.kbhit(), 0)
AssertionError: 1 != 0


Traceback (most recent call last):
  File "b:\uildarea\3.x.ware-win11.nondebug\build\Lib\test\test_msvcrt.py", line 77, in test_getwch
    self.assertEqual(msvcrt.getwch(), c)
AssertionError: '\n' != '\u5b57'
+ \u5b57
- 
-

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vstinner @bedevere-bot