Skip to content

gh-101100: Fix Sphinx warnings in tutorial/controlflow.rst #109424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 29, 2023
Merged

gh-101100: Fix Sphinx warnings in tutorial/controlflow.rst #109424

merged 2 commits into from
Sep 29, 2023

Conversation

m-aciek
Copy link
Contributor

@m-aciek m-aciek commented Sep 14, 2023 •
edited
Loading

It was:

…/cpython/Doc/tutorial/controlflow.rst:530: WARNING: py:meth reference target not found: list.append
…/cpython/Doc/tutorial/controlflow.rst:1049: WARNING: py:attr reference target not found: __annotations__

But, since both targets don't have an entry, we cannot reference them.

@bedevere-app bedevere-app bot mentioned this pull request Sep 14, 2023
Open
AA-Turner
AA-Turner approved these changes Sep 21, 2023
View reviewed changes
Copy link
Member

@AA-Turner AA-Turner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One note:

@AA-Turner AA-Turner added skip news needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes docs Documentation in the Doc dir labels Sep 21, 2023
@m-aciek @AA-Turner
Doc/tutorial/controlflow.rst: remove module prefix from append() meth…
1e53223 
…od reference

Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
hugovk
hugovk approved these changes Sep 29, 2023
View reviewed changes
Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@hugovk hugovk merged commit 8898a86 into python:main Sep 29, 2023
@miss-islington
Copy link
Contributor

Thanks @m-aciek for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 29, 2023
@m-aciek @AA-Turner @miss-islington
pythongh-101100: Fix Sphinx warnings in tutorial/controlflow.rst (p…
b69c477 
…ythonGH-109424)

(cherry picked from commit 8898a86)

Co-authored-by: Maciej Olko <maciej.olko@affirm.com>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 29, 2023
@m-aciek @AA-Turner @miss-islington
pythongh-101100: Fix Sphinx warnings in tutorial/controlflow.rst (p…
63404d6 
…ythonGH-109424)

(cherry picked from commit 8898a86)

Co-authored-by: Maciej Olko <maciej.olko@affirm.com>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
@bedevere-app
Copy link

bedevere-app bot commented Sep 29, 2023

GH-110084 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Sep 29, 2023
@bedevere-app
Copy link

bedevere-app bot commented Sep 29, 2023

GH-110085 is a backport of this pull request to the 3.11 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.11 only security fixes label Sep 29, 2023
hugovk pushed a commit that referenced this pull request Sep 29, 2023
@miss-islington @m-aciek @AA-Turner
[3.11] gh-101100: Fix Sphinx warnings in tutorial/controlflow.rst (G…
58ac0ed 
…H-109424) (#110085)

Co-authored-by: Maciej Olko <maciej.olko@affirm.com>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Yhg1s pushed a commit that referenced this pull request Sep 29, 2023
@miss-islington @m-aciek @AA-Turner
[3.12] gh-101100: Fix Sphinx warnings in tutorial/controlflow.rst (G…
c89844a 
…H-109424) (#110084)

gh-101100: Fix Sphinx warnings in `tutorial/controlflow.rst` (GH-109424)
(cherry picked from commit 8898a86)

Co-authored-by: Maciej Olko <maciej.olko@affirm.com>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
@m-aciek m-aciek deleted the sphinx-clean-tutorial-controlflow branch August 29, 2024 09:31
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@m-aciek @AA-Turner @Glyphack
pythongh-101100: Fix Sphinx warnings in tutorial/controlflow.rst (p…
0080e93 
…ython#109424)

Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugovk hugovk hugovk approved these changes

@AA-Turner AA-Turner AA-Turner approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@m-aciek @miss-islington @hugovk @AA-Turner