Skip to content

gh-109706: Fix multiprocessing test_nested_startmethod() #109707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 22, 2023
Merged

gh-109706: Fix multiprocessing test_nested_startmethod() #109707

merged 1 commit into from
Sep 22, 2023

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Sep 22, 2023 •
edited by bedevere-app bot
Loading

Don't check order, queue items can be written in any order.

@vstinner
pythongh-109706: Fix multiprocessing test_nested_startmethod()
06aa63b 
Don't check order, queue items can be written in any order.
@vstinner vstinner added tests Tests in the Lib/test dir needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Sep 22, 2023
@bedevere-app bedevere-app bot mentioned this pull request Sep 22, 2023
Closed
@vstinner vstinner mentioned this pull request Sep 22, 2023
Merged
@vstinner
Copy link
Member Author

cc @pitrou

pitrou
pitrou approved these changes Sep 22, 2023
View reviewed changes
Copy link
Member

@pitrou pitrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks. This behavior is arguably non-intuitive...

@vstinner
Copy link
Member Author

LGTM, thanks. This behavior is arguably non-intuitive...

Well... I'm no longer surprised by surprising multiprocessing behavior :-D

@vstinner vstinner merged commit b03a791 into python:main Sep 22, 2023
@vstinner vstinner deleted the test_nested_startmethod branch September 22, 2023 21:49
@miss-islington
Copy link
Contributor

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 22, 2023
@vstinner @miss-islington
pythongh-109706: Fix multiprocessing test_nested_startmethod() (pytho…
a83132f 
…nGH-109707)

Don't check order, queue items can be written in any order.
(cherry picked from commit b03a791)

Co-authored-by: Victor Stinner <vstinner@python.org>
@bedevere-app
Copy link

bedevere-app bot commented Sep 22, 2023

GH-109762 is a backport of this pull request to the 3.12 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 22, 2023
@vstinner @miss-islington
pythongh-109706: Fix multiprocessing test_nested_startmethod() (pytho…
9b81414 
…nGH-109707)

Don't check order, queue items can be written in any order.
(cherry picked from commit b03a791)

Co-authored-by: Victor Stinner <vstinner@python.org>
@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Sep 22, 2023
@bedevere-app
Copy link

bedevere-app bot commented Sep 22, 2023

GH-109763 is a backport of this pull request to the 3.11 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.11 only security fixes label Sep 22, 2023
@vstinner
Copy link
Member Author

Merged. Thanks for the review @pitrou. I wasn't sure about that one!

vstinner added a commit that referenced this pull request Sep 22, 2023
@miss-islington @vstinner
[3.11] gh-109706: Fix multiprocessing test_nested_startmethod() (GH-1…
3db2ec2 
…09707) (#109763)

gh-109706: Fix multiprocessing test_nested_startmethod() (GH-109707)

Don't check order, queue items can be written in any order.
(cherry picked from commit b03a791)

Co-authored-by: Victor Stinner <vstinner@python.org>
csm10495 pushed a commit to csm10495/cpython that referenced this pull request Sep 28, 2023
@vstinner @csm10495
pythongh-109706: Fix multiprocessing test_nested_startmethod() (pytho…
0066283 
…n#109707)

Don't check order, queue items can be written in any order.
Yhg1s pushed a commit that referenced this pull request Oct 2, 2023
@miss-islington @vstinner
[3.12] gh-109706: Fix multiprocessing test_nested_startmethod() (GH-1…
6a6bea3 
…09707) (#109762)

gh-109706: Fix multiprocessing test_nested_startmethod() (GH-109707)

Don't check order, queue items can be written in any order.
(cherry picked from commit b03a791)

Co-authored-by: Victor Stinner <vstinner@python.org>
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@vstinner @Glyphack
pythongh-109706: Fix multiprocessing test_nested_startmethod() (pytho…
ba451d2 
…n#109707)

Don't check order, queue items can be written in any order.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pitrou pitrou pitrou approved these changes

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vstinner @miss-islington @pitrou