[3.11] gh-109634: Use :samp: role (GH-109635) #109778
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 92af0cc) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
This was referenced Sep 23, 2023
Closed
JacobCoffee
requested changes
Sep 28, 2023
|
🤦♂️ Good catch @JacobCoffee. Do you mind to create a PR for main branch? |
|
Would this be based off of this branch or just with the fixes found? |
Co-authored-by: Jacob Coffee <jacob@z7x.org>
|
Since the original changes were already merged in main and 3.12, they only need fixes. Note my corrections of two of your suggestions. |
JacobCoffee
added a commit
to JacobCoffee/cpython
that referenced
this pull request
Sep 29, 2023
|
#110073 is ready for you @serhiy-storchaka |
JacobCoffee
approved these changes
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit 92af0cc)
📚 Documentation preview 📚: https://cpython-previews--109778.org.readthedocs.build/