Skip to content

[3.12] GH-109190: Copyedit 3.12 What's New: Improve the C-API deprecations section (GH-109751) #109830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 26, 2023
Merged

[3.12] GH-109190: Copyedit 3.12 What's New: Improve the C-API deprecations section (GH-109751) #109830

merged 2 commits into from
Sep 26, 2023

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Sep 25, 2023 •
edited by github-actions bot
Loading

(cherry picked from commit bccc1b7)

Co-authored-by: Adam Turner 9087854+AA-Turner@users.noreply.github.com
Co-authored-by: Serhiy Storchaka storchaka@gmail.com

📚 Documentation preview 📚: https://cpython-previews--109830.org.readthedocs.build/

@AA-Turner @serhiy-storchaka @miss-islington
pythonGH-109190: Copyedit 3.12 What's New: Improve the C-API deprecat…
ee25e38 
…ions section (pythonGH-109751)

(cherry picked from commit bccc1b7)

Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-app bedevere-app bot added awaiting review docs Documentation in the Doc dir skip news labels Sep 25, 2023
This was referenced Sep 25, 2023
Closed
Merged
@hugovk
Copy link
Member

hugovk commented Sep 25, 2023 •
edited
Loading

@AA-Turner We're getting a CI failure on this one:

Emitting doc warnings matching modified lines:
Warning: c:func reference target not found: PyWeakref_GetRef
/home/runner/work/cpython/cpython/Doc/whatsnew/3.12.rst:2176: WARNING: c:func reference target not found: PyWeakref_GetRef
Warning: c:func reference target not found: PyWeakref_GetRef
/home/runner/work/cpython/cpython/Doc/whatsnew/3.12.rst:2177: WARNING: c:func reference target not found: PyWeakref_GetRef

Error: must not contain warnings:

Doc/whatsnew/3.12.rst
  2176: c:func reference target not found: PyWeakref_GetRef
  2177: c:func reference target not found: PyWeakref_GetRef

@AA-Turner
Copy link
Member

AA-Turner commented Sep 25, 2023 •
edited
Loading

Oh, looks like one of the 3.13 deprecations slipped through. I'll push to this PR & open a new one.

Edit: What's actually happened is that I listed all the functions pending removal in Python 3.15 in an attempt to give C developers more notice, but several of these aren't deprecated in Python 3.12. I've removed the two offending lines here as the replacement function was only added in Python 3.13, so I don't think there's benefit to listing them in the 3.12 What's New given nothing can be done by programmers to port their usages.

A

@hugovk
Copy link
Member

hugovk commented Sep 25, 2023

Thanks, let's also update Doc/whatsnew/3.12.rst in main to match.

@AA-Turner AA-Turner mentioned this pull request Sep 25, 2023
Merged
@Yhg1s Yhg1s merged commit a192517 into python:3.12 Sep 26, 2023
@miss-islington miss-islington deleted the backport-bccc1b7-3.12 branch September 26, 2023 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugovk hugovk hugovk approved these changes

@AA-Turner AA-Turner AA-Turner approved these changes

Assignees

@Yhg1s Yhg1s

Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@miss-islington @hugovk @AA-Turner @Yhg1s