-
-
Notifications
You must be signed in to change notification settings - Fork 31.8k
gh-109408: Stop running patchcheck in CI #109895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-109408: Stop running patchcheck in CI #109895
Conversation
d707f5c
to
269bebe
Compare
If I understand Éric's comments correctly, they don't block this PR itself, but more speak to improving the experience of running CPython's linting tools. In an effort to unblock this PR, I have opened #122333 as a sketch proposal. A |
I’m not active enough for my comments to have weight here. But you could have a discussion in the core-dev discuss forum to check agreement and avoid people being surprised after the fact. |
We did last year (https://discuss.python.org/t/34743), which I don't think raised any opposition to removing the (now duplicative) whitespace checks in CI. The wider patchcheck tool will remain, and #122333 will hopefully give us a unified 'local static checks' target. If/when that's merged, I think telling people on Discourse as a reminder would be useful. A |
It's been a week or so with no comment (and a year since the PR was opened), so I'll go ahead and merge this. If things go wrong we can always revert. A |
Requires #109854; #109890; and #109891