Use quiet=True by default

python · sobolevn · Sep 28, 2023 · Sep 28, 2023 · Sep 28, 2023 · Sep 28, 2023
commit dfda2548a56ed73cb78ac076fcdf52f28e456afd
diff --git a/Lib/test/test_socket.py b/Lib/test/test_socket.py
@@ -167,7 +167,8 @@ def socket_setdefaulttimeout(timeout):
 
 
 @contextlib.contextmanager
-def catch_malformed_data_warning(quiet=False):
+def catch_malformed_data_warning(quiet=True):
 def _filterwarnings(filters, quiet=False): 
     """Catch the warnings, then check if all the expected 
     warnings have been raised and re-raise unexpected warnings. 
     If 'quiet' is True, only re-raise the unexpected warnings. 
     """ 
     # Clear the warning registry of the calling module 
     # in order to re-raise the warnings. 
     frame = sys._getframe(2) 
     registry = frame.f_globals.get('__warningregistry__') 
     if registry: 
         registry.clear() 
     with warnings.catch_warnings(record=True) as w: 
         # Set filter "always" to record all warnings.  Because 
         # test_warnings swap the module, we need to look up in 
         # the sys.modules dictionary. 
         sys.modules['warnings'].simplefilter("always") 
         yield WarningsRecorder(w) 
     # Filter the recorded warnings 
     reraise = list(w) 
     missing = [] 
     for msg, cat in filters: 
         seen = False 
         for w in reraise[:]: 
             warning = w.message 
             # Filter out the matching messages 
             if (re.match(msg, str(warning), re.I) and 
                 issubclass(warning.__class__, cat)): 
                 seen = True 
                 reraise.remove(w) 
         if not seen and not quiet: 
             # This filter caught nothing 
             missing.append((msg, cat.__name__)) 
     if reraise: 
         raise AssertionError("unhandled warning %s" % reraise[0]) 
     if missing: 
         raise AssertionError("filter (%r, %s) did not catch any warning" % 
                              missing[0]) 
 def _filterwarnings(filters, quiet=False): 
     """Catch the warnings, then check if all the expected 
     warnings have been raised and re-raise unexpected warnings. 
     If 'quiet' is True, only re-raise the unexpected warnings. 
     """ 
     # Clear the warning registry of the calling module 
     # in order to re-raise the warnings. 
     frame = sys._getframe(2) 
     registry = frame.f_globals.get('__warningregistry__') 
     if registry: 
         registry.clear() 
     with warnings.catch_warnings(record=True) as w: 
         # Set filter "always" to record all warnings.  Because 
         # test_warnings swap the module, we need to look up in 
         # the sys.modules dictionary. 
         sys.modules['warnings'].simplefilter("always") 
         yield WarningsRecorder(w) 
     # Filter the recorded warnings 
     reraise = list(w) 
     missing = [] 
     for msg, cat in filters: 
         seen = False 
         for w in reraise[:]: 
             warning = w.message 
             # Filter out the matching messages 
             if (re.match(msg, str(warning), re.I) and 
                 issubclass(warning.__class__, cat)): 
                 seen = True 
                 reraise.remove(w) 
         if not seen and not quiet: 
             # This filter caught nothing 
             missing.append((msg, cat.__name__)) 
     if reraise: 
         raise AssertionError("unhandled warning %s" % reraise[0]) 
     if missing: 
         raise AssertionError("filter (%r, %s) did not catch any warning" % 
                              missing[0]) 
+    # This warning happens on macos and win, but does not always happen on linux.
     with warnings_helper.check_warnings(
         ("received malformed or improperly-truncated ancillary data", RuntimeWarning),
         quiet=quiet,