Skip to content

gh-110267: Add tests for pickling and copying PyStructSequence objects #110272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 3, 2023
Merged

gh-110267: Add tests for pickling and copying PyStructSequence objects #110272

merged 4 commits into from
Oct 3, 2023

Conversation

XuehaiPan
Copy link
Contributor

@XuehaiPan XuehaiPan commented Oct 3, 2023 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot added tests Tests in the Lib/test dir awaiting review labels Oct 3, 2023
@bedevere-app bedevere-app bot mentioned this pull request Oct 3, 2023
Closed
@XuehaiPan XuehaiPan mentioned this pull request Oct 3, 2023
Merged
serhiy-storchaka
serhiy-storchaka reviewed Oct 3, 2023
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @XuehaiPan. I added a style nitpick, and I think that explicit tests for __reduce__() are no longer needed. It is an implementation detail, rarely tested explicitly.

@serhiy-storchaka serhiy-storchaka merged commit 2d4865d into python:main Oct 3, 2023
@serhiy-storchaka serhiy-storchaka added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Oct 3, 2023
@miss-islington
Copy link
Contributor

Thanks @XuehaiPan for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Thanks @XuehaiPan for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 3, 2023
@XuehaiPan @miss-islington
pythongh-110267: Add tests for pickling and copying PyStructSequence …
d0893dc 
…objects (pythonGH-110272)

(cherry picked from commit 2d4865d)

Co-authored-by: Xuehai Pan <XuehaiPan@pku.edu.cn>
@bedevere-app
Copy link

bedevere-app bot commented Oct 3, 2023

GH-110284 is a backport of this pull request to the 3.11 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.11 only security fixes label Oct 3, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 3, 2023
@XuehaiPan @miss-islington
pythongh-110267: Add tests for pickling and copying PyStructSequence …
dbab1b0 
…objects (pythonGH-110272)

(cherry picked from commit 2d4865d)

Co-authored-by: Xuehai Pan <XuehaiPan@pku.edu.cn>
@bedevere-app
Copy link

bedevere-app bot commented Oct 3, 2023

GH-110285 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Oct 3, 2023
@XuehaiPan XuehaiPan deleted the test-structseq-pickle-copy branch October 3, 2023 15:23
serhiy-storchaka pushed a commit that referenced this pull request Oct 4, 2023
@miss-islington @XuehaiPan
[3.12] gh-110267: Add tests for pickling and copying PyStructSequence…
35feda5 
… objects (GH-110272) (GH-110285)

(cherry picked from commit 2d4865d)

Co-authored-by: Xuehai Pan <XuehaiPan@pku.edu.cn>
serhiy-storchaka pushed a commit that referenced this pull request Oct 4, 2023
@miss-islington @XuehaiPan
[3.11] gh-110267: Add tests for pickling and copying PyStructSequence…
5039db7 
… objects (GH-110272) (GH-110284)

(cherry picked from commit 2d4865d)

Co-authored-by: Xuehai Pan <XuehaiPan@pku.edu.cn>
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@XuehaiPan @Glyphack
pythongh-110267: Add tests for pickling and copying PyStructSequence …
d3aa0f1 
…objects (pythonGH-110272)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Assignees
No one assigned
Labels
tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add tests for pickling and copying PyStructSequence objects
3 participants
@XuehaiPan @miss-islington @serhiy-storchaka