Skip to content

gh-110378: Move to IsolatedAsyncTestCase in test_contextlib_async.py #110379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 8, 2023
Merged

gh-110378: Move to IsolatedAsyncTestCase in test_contextlib_async.py #110379

merged 1 commit into from
Oct 8, 2023

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Oct 5, 2023 •
edited
Loading

After the change:

~/Desktop/cpython  main ✗                                                                 
» ./python.exe -m test test_contextlib_async
Using random seed 451969388
0:00:00 load avg: 1.34 Run 1 test sequentially
0:00:00 load avg: 1.34 [1/1] test_contextlib_async

== Tests result: SUCCESS ==

1 test OK.

Total duration: 99 ms
Total tests: run=58
Total test files: run=1/1
Result: SUCCESS

~/Desktop/cpython  main ✗                                                                 
» ./python.exe Lib/test/test_contextlib_async.py
..........................................................
----------------------------------------------------------------------
Ran 58 tests in 0.063s

OK

@sobolevn sobolevn requested a review from 1st1 as a code owner October 5, 2023 08:04
@bedevere-app bedevere-app bot added tests Tests in the Lib/test dir awaiting review labels Oct 5, 2023
@bedevere-app bedevere-app bot mentioned this pull request Oct 5, 2023
Closed
kumaraditya303
kumaraditya303 approved these changes Oct 8, 2023
View reviewed changes
Copy link
Contributor

@kumaraditya303 kumaraditya303 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kumaraditya303 kumaraditya303 merged commit 6780d63 into python:main Oct 8, 2023
@sobolevn
Copy link
Member Author

sobolevn commented Oct 8, 2023

@kumaraditya303 #110378 (comment) It was asked by @serhiy-storchaka to merge this PR after two of his PRs :)

@kumaraditya303
Copy link
Contributor

Oh, I didn't see that comment, sorry, but the changes are parallel so can be merged in any order.

@serhiy-storchaka
Copy link
Member

It just makes writing and testing other changes more difficult, because IsolatedAsyncTestCase automatically closes suspended generators.

Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@sobolevn @Glyphack
pythongh-110378: Move to IsolatedAsyncTestCase in `test_contextlib_…
b3ca398 
…async.py` (python#110379)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sobolevn @kumaraditya303 @serhiy-storchaka