Skip to content

gh-110415: move datetime global state into module state #110420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 9 commits into from
Closed

gh-110415: move datetime global state into module state #110420

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
c82d32a
fix: make datetime mostly subinterpreter friendly
costasgambit Oct 3, 2023
89cbd78
fix: test is wrong?
costasgambit Oct 3, 2023
e1603ff
fix: port the rest of datetime to use module state
costasgambit Oct 3, 2023
1b4c96a
fix: clean up the macros
costasgambit Oct 6, 2023
94b3788
fix: typo
costasgambit Oct 6, 2023
681d7c8
fix: brackets in macros just in case
costasgambit Oct 6, 2023
68c7ec1
fix: ZoneInfo warning about base needing to be immutable
costasgambit Oct 6, 2023
2093f8a
chore: add news blurb
costasgambit Oct 6, 2023
3f9fd1e
Merge branch '3.12' into costas--py3.12-datetime
abalkin Oct 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Lib/test/datetimetester.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ def test_name_cleanup(self):
if not name.startswith('__') and not name.endswith('__'))
allowed = set(['MAXYEAR', 'MINYEAR', 'date', 'datetime',
'datetime_CAPI', 'time', 'timedelta', 'timezone',
'tzinfo', 'UTC', 'sys'])
'tzinfo', 'UTC', 'sys', 'IsoCalendarDate'])
self.assertEqual(names - allowed, set([]))

def test_divide_and_round(self):
Expand Down
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Core and Builtins/2023-10-06-02-41-31.gh-issue-110415.rALDjU.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fixed crash when importing datetime from multiple sub-interpreters.
Loading