Skip to content

gh-110437: Allow overriding VCRuntimeDLL with a semicolon separated list of DLLs to bundle #110470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 9, 2023
Merged

gh-110437: Allow overriding VCRuntimeDLL with a semicolon separated list of DLLs to bundle #110470

merged 1 commit into from
Oct 9, 2023

Conversation

zooba
Copy link
Member

@zooba zooba commented Oct 6, 2023 •
edited by bedevere-app bot
Loading

Related change to our release build is at python/release-tools#63

There's no need for us to always override the DLLs, but it's useful to do it when building installers.

@zooba zooba added OS-windows needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Oct 6, 2023
@zooba zooba requested a review from a team as a code owner October 6, 2023 13:29
@bedevere-app bedevere-app bot mentioned this pull request Oct 6, 2023
Closed
@zooba zooba merged commit 12cc679 into python:main Oct 9, 2023
@miss-islington
Copy link
Contributor

Thanks @zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

@zooba zooba deleted the gh-110437 branch October 9, 2023 11:17
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 9, 2023
@zooba @miss-islington
pythongh-110437: Allow overriding VCRuntimeDLL with a semicolon separ…
bbc8341 
…ated list of DLLs to bundle (pythonGH-110470)

(cherry picked from commit 12cc679)

Co-authored-by: Steve Dower <steve.dower@python.org>
@bedevere-app
Copy link

bedevere-app bot commented Oct 9, 2023

GH-110555 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Oct 9, 2023
@bedevere-app
Copy link

bedevere-app bot commented Oct 9, 2023

GH-110556 is a backport of this pull request to the 3.11 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.11 only security fixes label Oct 9, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 9, 2023
@zooba @miss-islington
pythongh-110437: Allow overriding VCRuntimeDLL with a semicolon separ…
03c108f 
…ated list of DLLs to bundle (pythonGH-110470)

(cherry picked from commit 12cc679)

Co-authored-by: Steve Dower <steve.dower@python.org>
zooba added a commit that referenced this pull request Oct 9, 2023
@miss-islington @zooba
[3.12] gh-110437: Allow overriding VCRuntimeDLL with a semicolon sepa…
13ad121 
…rated list of DLLs to bundle (GH-110470)

gh-110437: Allow overriding VCRuntimeDLL with a semicolon separated list of DLLs to bundle (GH-110470)
(cherry picked from commit 12cc679)

Co-authored-by: Steve Dower <steve.dower@python.org>
zooba added a commit that referenced this pull request Oct 9, 2023
@miss-islington @zooba
[3.11] gh-110437: Allow overriding VCRuntimeDLL with a semicolon sepa…
26c3e70 
…rated list of DLLs to bundle (GH-110470)

gh-110437: Allow overriding VCRuntimeDLL with a semicolon separated list of DLLs to bundle (GH-110470)
(cherry picked from commit 12cc679)

Co-authored-by: Steve Dower <steve.dower@python.org>
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@zooba @Glyphack
pythongh-110437: Allow overriding VCRuntimeDLL with a semicolon separ…
a4cbc43 
…ated list of DLLs to bundle (pythonGH-110470)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
OS-windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zooba @miss-islington