gh-110378: Fix test_async_gen_propagates_generator_exit in test_contextlib_async #110500
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_contextlib_async It now fails if the original bug is not fixed, and no longer produce ResourceWarning with fixed code.
|
After 6780d63 there are no RuntimeWarnings visible on Ubuntu and macOS so I had to revert that to confirm this PR is indeed solving the core issue. Without the change: This warning doesn't appear after the change. |
|
Thanks @serhiy-storchaka for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 10, 2023
…_contextlib_async (pythonGH-110500) It now fails if the original bug is not fixed, and no longer produce ResourceWarning with fixed code. (cherry picked from commit 5aa62a8) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
|
GH-110610 is a backport of this pull request to the 3.12 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 10, 2023
…_contextlib_async (pythonGH-110500) It now fails if the original bug is not fixed, and no longer produce ResourceWarning with fixed code. (cherry picked from commit 5aa62a8) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
|
GH-110611 is a backport of this pull request to the 3.11 branch. |
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
…_contextlib_async (python#110500) It now fails if the original bug is not fixed, and no longer produce ResourceWarning with fixed code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It now fails if the original bug is not fixed, and no longer produce ResourceWarning with fixed code.
test_contextlib_asyncproduces severalRuntimeWarnings #110378