Skip to content

Update floatingpoint.rst #110509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 8, 2023
Merged

Update floatingpoint.rst #110509

merged 1 commit into from
Oct 8, 2023

Conversation

zipperer
Copy link
Contributor

@zipperer zipperer commented Oct 7, 2023

This commit removes a ':'. I believe the extra colon causes a display error.

What I believe to be an error:
Above this expression
round(math.pi, ndigits=2) == round(22 / 7, ndigits=2) the page displays .. doctest::.

What I observed:
After I remove the extra colon, the page does not display .. doctest::


📚 Documentation preview 📚: https://cpython-previews--110509.org.readthedocs.build/

This commit removes a ':'. I believe the extra colon causes a display error.

What I believe to be an error:
Above this expression
`round(math.pi, ndigits=2) == round(22 / 7, ndigits=2)`
the page displays `.. doctest::`.

What I observed:
After I remove the extra colon, the page does not display `.. doctest::`
@ghost
Copy link

ghost commented Oct 7, 2023

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-app bedevere-app bot added docs Documentation in the Doc dir skip news awaiting review labels Oct 7, 2023
@zipperer
Copy link
Contributor Author

zipperer commented Oct 7, 2023

Before remove extra colon
page_display_before_remove_extra_colon

After remove extra colon
page_display_after_remove_extra_colon

Copy link
Member

@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, good catch

@miss-islington
Copy link
Contributor

Thanks @zipperer for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington
Copy link
Contributor

Sorry, @zipperer and @JelleZijlstra, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 8e56d551ceef37a307280bcc5303bf69ccc9f9c1 3.11

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 8, 2023
This commit removes a ':'. I believe the extra colon causes a display error.

What I believe to be an error:
Above this expression
`round(math.pi, ndigits=2) == round(22 / 7, ndigits=2)`
the page displays `.. doctest::`.

What I observed:
After I remove the extra colon, the page does not display `.. doctest::`
(cherry picked from commit 8e56d55)

Co-authored-by: zipperer <47086307+zipperer@users.noreply.github.com>
@bedevere-app
Copy link

bedevere-app bot commented Oct 8, 2023

GH-110513 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Oct 8, 2023
@JelleZijlstra
Copy link
Member

This section isn't in the 3.11 docs, so the 3.12 backport is enough. Thanks for the fix!

@JelleZijlstra JelleZijlstra removed the needs backport to 3.11 only security fixes label Oct 8, 2023
JelleZijlstra pushed a commit that referenced this pull request Oct 8, 2023
Update floatingpoint.rst (GH-110509)

This commit removes a ':'. I believe the extra colon causes a display error.

What I believe to be an error:
Above this expression
`round(math.pi, ndigits=2) == round(22 / 7, ndigits=2)`
the page displays `.. doctest::`.

What I observed:
After I remove the extra colon, the page does not display `.. doctest::`
(cherry picked from commit 8e56d55)

Co-authored-by: zipperer <47086307+zipperer@users.noreply.github.com>
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
This commit removes a ':'. I believe the extra colon causes a display error.

What I believe to be an error:
Above this expression
`round(math.pi, ndigits=2) == round(22 / 7, ndigits=2)`
the page displays `.. doctest::`.

What I observed:
After I remove the extra colon, the page does not display `.. doctest::`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants