Skip to content

gh-109094: remove redundant arg to _PyFrame_PushTrampolineUnchecked #110759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 12, 2023

Conversation

iritkatriel
Copy link
Member

@iritkatriel iritkatriel commented Oct 12, 2023

The prev_instr arg is not actually used (always passed 0). I suggest removing it rather than migrating it to instr_ptr, since there are no tests to tell us if we're doing it right. It would not be hard to re-implement this if and when we need it.

@iritkatriel iritkatriel added skip news interpreter-core (Objects, Python, Grammar, and Parser dirs) labels Oct 12, 2023
@iritkatriel iritkatriel changed the title gh-109095: remove redundant arg to _PyFrame_PushTrampolineUnchecked gh-109094: remove redundant arg to _PyFrame_PushTrampolineUnchecked Oct 12, 2023
@markshannon
Copy link
Member

👍

@markshannon markshannon merged commit 7dd3c2b into python:main Oct 12, 2023
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
interpreter-core (Objects, Python, Grammar, and Parser dirs) skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants