Skip to content

gh-110938: Add several missing syntax tests for PEP695 funcs and classes #110986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 18, 2023
Merged

gh-110938: Add several missing syntax tests for PEP695 funcs and classes #110986

merged 1 commit into from
Oct 18, 2023

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Oct 17, 2023 •
edited
Loading

@sobolevn sobolevn requested a review from pablogsal October 17, 2023 13:46
@bedevere-app bedevere-app bot mentioned this pull request Oct 17, 2023
Closed
@bedevere-app bedevere-app bot added awaiting review tests Tests in the Lib/test dir labels Oct 17, 2023
Eclips4
Eclips4 approved these changes Oct 17, 2023
View reviewed changes
Copy link
Member

@Eclips4 Eclips4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hauntsaninja hauntsaninja added the needs backport to 3.12 only security fixes label Oct 18, 2023
@hauntsaninja hauntsaninja merged commit 220bcc9 into python:main Oct 18, 2023
@miss-islington-app
Copy link

Thanks @sobolevn for the PR, and @hauntsaninja for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 18, 2023
@sobolevn @miss-islington
pythongh-110938: More syntax tests for PEP695 funcs and classes (pyth…
896a88d 
…onGH-110986)

(cherry picked from commit 220bcc9)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@bedevere-app
Copy link

bedevere-app bot commented Oct 18, 2023

GH-111023 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Oct 18, 2023
JelleZijlstra pushed a commit that referenced this pull request Oct 18, 2023
@miss-islington @sobolevn
[3.12] gh-110938: More syntax tests for PEP695 funcs and classes (GH-…
004618f 
…110986) (#111023)

gh-110938: More syntax tests for PEP695 funcs and classes (GH-110986)
(cherry picked from commit 220bcc9)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@sobolevn @aisk
pythongh-110938: More syntax tests for PEP695 funcs and classes (pyth…
772c883 
…on#110986)
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@sobolevn @Glyphack
pythongh-110938: More syntax tests for PEP695 funcs and classes (pyth…
e75fce1 
…on#110986)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hauntsaninja hauntsaninja hauntsaninja approved these changes

@Eclips4 Eclips4 Eclips4 approved these changes

@pablogsal pablogsal Awaiting requested review from pablogsal

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sobolevn @hauntsaninja @Eclips4