Skip to content

gh-111046: for wasi-threads, export memory as well #111099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 20, 2023
Merged

gh-111046: for wasi-threads, export memory as well #111099

merged 3 commits into from
Oct 20, 2023
+11 −0

Conversation

yamt
Copy link
Contributor

@yamt yamt commented Oct 20, 2023 •
edited by bedevere-app bot
Loading

with the latest spec, we should import and export memory for wasi-threads.
some runtimes (eg. wasmtime) actually rely on it.

issue: #111046

tested with: toywasm, wasmtime

@bedevere-app bedevere-app bot mentioned this pull request Oct 20, 2023
Closed
@erlend-aasland
Copy link
Contributor

I'll let Brett (or another WASI expert) take care of this. The configure.ac change is fine.

@brettcannon brettcannon added the needs backport to 3.12 only security fixes label Oct 20, 2023
@brettcannon brettcannon self-assigned this Oct 20, 2023
@brettcannon brettcannon merged commit 5dfa717 into python:main Oct 20, 2023
@miss-islington-app
Copy link

Thanks @yamt for the PR, and @brettcannon for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@brettcannon
Copy link
Member

@yamt thanks!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 20, 2023
@yamt @miss-islington
pythongh-111046: for wasi-threads, export memory as well via the link…
aafa2ec 
…er (pythonGH-111099)

(cherry picked from commit 5dfa717)

Co-authored-by: YAMAMOTO Takashi <yamamoto@midokura.com>
@bedevere-app
Copy link

bedevere-app bot commented Oct 20, 2023

GH-111141 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Oct 20, 2023
brettcannon pushed a commit that referenced this pull request Oct 20, 2023
@miss-islington @yamt
[3.12] gh-111046: for wasi-threads, export memory as well via the lin…
727f8ee 
…ker (GH-111099) (GH-111141)

gh-111046: for wasi-threads, export memory as well via the linker (GH-111099)
(cherry picked from commit 5dfa717)

Co-authored-by: YAMAMOTO Takashi <yamamoto@midokura.com>
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@yamt @aisk
pythongh-111046: for wasi-threads, export memory as well via the link…
701f274 
…er (pythonGH-111099)
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@yamt @Glyphack
pythongh-111046: for wasi-threads, export memory as well via the link…
8c8fd5a 
…er (pythonGH-111099)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brettcannon brettcannon brettcannon approved these changes

@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner

@corona10 corona10 Awaiting requested review from corona10 corona10 is a code owner

Assignees

@brettcannon brettcannon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yamt @erlend-aasland @brettcannon