Skip to content

gh-111282: Fix NamedTemporaryFile example code #111283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 31, 2023
Merged

gh-111282: Fix NamedTemporaryFile example code #111283

merged 4 commits into from
Oct 31, 2023

Conversation

kkarbowiak
Copy link
Contributor

@kkarbowiak kkarbowiak commented Oct 24, 2023 •
edited by github-actions bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Oct 24, 2023
Closed
@bedevere-app bedevere-app bot added awaiting review docs Documentation in the Doc dir skip news labels Oct 24, 2023
@Eclips4 Eclips4 added the needs backport to 3.12 only security fixes label Oct 24, 2023
Eclips4
Eclips4 reviewed Oct 24, 2023
View reviewed changes
Eclips4
Eclips4 approved these changes Oct 24, 2023
View reviewed changes
Copy link
Member

@Eclips4 Eclips4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

zware
zware reviewed Oct 30, 2023
View reviewed changes
@zware zware merged commit 102685c into python:main Oct 31, 2023
@miss-islington-app
Copy link

Thanks @kkarbowiak for the PR, and @zware for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 31, 2023
@kkarbowiak @miss-islington
pythongh-111282: Fix NamedTemporaryFile example code (pythonGH-111283)
d7a2f3a 
(cherry picked from commit 102685c)

Co-authored-by: Krzysiek Karbowiak <krzysztof.karbowiak@interia.pl>
@bedevere-app
Copy link

bedevere-app bot commented Oct 31, 2023

GH-111579 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Oct 31, 2023
zware pushed a commit that referenced this pull request Oct 31, 2023
@miss-islington @kkarbowiak
[3.12] gh-111282: Fix NamedTemporaryFile example code (GH-111283) (GH…
21c8fbf 
…-111579)

(cherry picked from commit 102685c)

Co-authored-by: Krzysiek Karbowiak <krzysztof.karbowiak@interia.pl>
@kkarbowiak kkarbowiak deleted the fix-issue-gh111282 branch October 31, 2023 22:17
FullteaR pushed a commit to FullteaR/cpython that referenced this pull request Nov 3, 2023
@kkarbowiak @FullteaR
pythongh-111282: Fix NamedTemporaryFile example code (pythonGH-111283)
b0b2341
@sobolevn sobolevn mentioned this pull request Nov 3, 2023
Open
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@kkarbowiak @aisk
pythongh-111282: Fix NamedTemporaryFile example code (pythonGH-111283)
57fcaa0
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@kkarbowiak @Glyphack
pythongh-111282: Fix NamedTemporaryFile example code (pythonGH-111283)
8b55c24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zware zware zware approved these changes

@Eclips4 Eclips4 Eclips4 approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kkarbowiak @zware @Eclips4