Skip to content

gh-107265: Fix _PyFrame_OpAlreadyRan for ENTER_EXECUTOR case #111645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

gh-107265: Fix _PyFrame_OpAlreadyRan for ENTER_EXECUTOR case #111645

wants to merge 3 commits into from

Conversation

corona10
Copy link
Member

@corona10 corona10 commented Nov 2, 2023 •
edited by bedevere-app bot
Loading

@corona10 corona10 requested a review from markshannon as a code owner November 2, 2023 13:48
@bedevere-app bedevere-app bot mentioned this pull request Nov 2, 2023
Open
10 tasks
@corona10
Copy link
Member Author

corona10 commented Nov 2, 2023

_PyFrame_OpAlreadyRan is only called for MAKE_CELL right now.
So it might be a low possibility that it will make an issue in the current situation.
But it should handle ENTER_EXECUTOR opcode case when comparing the opcode.

@gvanrossum
Copy link
Member

I will have to delay reviewing this, but my immediate reaction is that we want to make this function unnecessary, not more complicated.

@corona10
Copy link
Member Author

corona10 commented Nov 2, 2023

I will have to delay reviewing this, but my immediate reaction is that we want to make this function unnecessary, not more complicated.

Yeah, I also agree that way too.

@corona10 corona10 closed this Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently

@gvanrossum gvanrossum Awaiting requested review from gvanrossum

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Assignees
No one assigned
Labels
awaiting core review skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@corona10 @gvanrossum