Skip to content

gh-111741: Recognise image/webp as a standard format in the mimetypes module. #111742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

Nachtalb
Copy link
Contributor

@Nachtalb Nachtalb commented Nov 4, 2023

WEBP is not recognised as a standard type and demands the user to use strict=False as in mimetypes.guess_type("foobar.webp", strict=False) to recognise it. This is because it was previously not recognised by IANA as an official type.

Since the introduction of webp support in the mimetypes module in #89802 it has officially been accepted to IANA and thus is not a "non-standard format" anymore.

Refs:

@Nachtalb Nachtalb requested a review from a team as a code owner November 4, 2023 21:37
@ghost
Copy link

ghost commented Nov 4, 2023

All commit authors signed the Contributor License Agreement.
CLA signed

Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@serhiy-storchaka serhiy-storchaka merged commit b905fad into python:main Jan 31, 2024
@Nachtalb Nachtalb deleted the fix-issue-111741 branch February 2, 2024 20:39
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
…etypes module (pythonGH-111742)

Previously it was supported as a non-standard type.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants