Skip to content

gh-111765: move old PyFloat_* tests to Lib/test/test_capi/test_float.py #111766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 7, 2023
Merged

gh-111765: move old PyFloat_* tests to Lib/test/test_capi/test_float.py #111766

merged 2 commits into from
Nov 7, 2023
+65 −65

Conversation

skirpichev
Copy link
Member

@skirpichev skirpichev commented Nov 6, 2023 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Nov 6, 2023
Closed
@bedevere-app bedevere-app bot added the tests Tests in the Lib/test dir label Nov 6, 2023
@skirpichev
Copy link
Member Author

@AlexWaygood, probably this also can skip news?

@skirpichev
Copy link
Member Author

CC @serhiy-storchaka

serhiy-storchaka
serhiy-storchaka approved these changes Nov 7, 2023
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I was going to suggest you make these changes, but it was obvious, so you already made them.

@serhiy-storchaka serhiy-storchaka merged commit a077b2f into python:main Nov 7, 2023
@serhiy-storchaka serhiy-storchaka added the needs backport to 3.12 only security fixes label Nov 7, 2023
@miss-islington-app
Copy link

Thanks @skirpichev for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 7, 2023
@skirpichev @miss-islington
pythongh-111765: Move old PyFloat_* tests to Lib/test/test_capi/test_…
fa4e7dd 
…float.py (pythonGH-111766)

(cherry picked from commit a077b2f)

Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Nov 7, 2023

GH-111818 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Nov 7, 2023
@skirpichev skirpichev deleted the move-pack-unpack-tests-111765 branch November 7, 2023 11:51
@skirpichev
Copy link
Member Author

I was going to suggest you make these changes

That was actually suggested in #111624.

serhiy-storchaka pushed a commit that referenced this pull request Nov 7, 2023
@miss-islington @skirpichev
[3.12] gh-111765: Move old PyFloat_* tests to Lib/test/test_capi/test…
f70ae99 
…_float.py (GH-111766) (GH-111818)

(cherry picked from commit a077b2f)

Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
hugovk pushed a commit to hugovk/cpython that referenced this pull request Nov 8, 2023
@skirpichev @hugovk
pythongh-111765: Move old PyFloat_* tests to Lib/test/test_capi/test_…
98b5117 
…float.py (pythonGH-111766)
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@skirpichev @aisk
pythongh-111765: Move old PyFloat_* tests to Lib/test/test_capi/test_…
ab8345f 
…float.py (pythonGH-111766)
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@skirpichev @Glyphack
pythongh-111765: Move old PyFloat_* tests to Lib/test/test_capi/test_…
8e7f0aa 
…float.py (pythonGH-111766)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@skirpichev @serhiy-storchaka @AlexWaygood