Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gh-111495: Add tests for PyNumber C API #111996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-111495: Add tests for PyNumber C API #111996
Changes from all commits
cbca658
0d95d57
7b8adb4
4665f25
9e14905
c0f4051
3a7a4c4
788e9c2
8cf4429
91c68a7
9f6fd15
9f5b7a1
2675738
2bc6bc7
49d673b
b2dda89
b86d2eb
0fbbba9
bcf0c20
9aae51b
d052280
c04679c
efe4aab
4d96d35
b00365e
74abc5d
d62b802
7ba5bb0
76aac6f
de8f7f3
bd3435b
ab08430
0bccf1c
abde55b
f4be9c5
86df16c
c620c72
556b23b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you move
[0, 42, -1, 3.14, 1+2j]
to a module-level constant? Maybe: NUMBERS = [...].There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, I would prefer this be more local.