Skip to content

Remove imp_dummy_def from Tools/c-analyzer/cpython/ignored.tsv #112122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

sobolevn
Copy link
Member

It was removed in 3.12, no need to keep the ignore.

Copy link
Member

@ericsnowcurrently ericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sobolevn
Copy link
Member Author

sobolevn commented Nov 16, 2023

@ericsnowcurrently can you merge it? :)
Or is there anything left?

@ericsnowcurrently ericsnowcurrently merged commit 762eb58 into python:main Nov 16, 2023
@miss-islington-app
Copy link

Thanks @sobolevn for the PR, and @ericsnowcurrently for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 16, 2023
…ythongh-112122)

It was removed in 3.12, no need to keep the ignore.
(cherry picked from commit 762eb58)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@bedevere-app
Copy link

bedevere-app bot commented Nov 16, 2023

GH-112177 is a backport of this pull request to the 3.12 branch.

@ericsnowcurrently
Copy link
Member

Thanks for doing this.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Nov 16, 2023
ericsnowcurrently pushed a commit that referenced this pull request Nov 16, 2023
…tsv` (gh-112122) (gh-112177)

It was removed in 3.12, no need to keep the ignore.
(cherry picked from commit 762eb58)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
…ythongh-112122)

It was removed in 3.12, no need to keep the ignore.
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
…ythongh-112122)

It was removed in 3.12, no need to keep the ignore.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants