Skip to content

gh-111811: Fix test_recursive_repr for WASI #112130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 15, 2023
Merged

Conversation

kushaldas
Copy link
Member

@kushaldas kushaldas commented Nov 15, 2023

@brettcannon
Copy link
Member

!buildbot wasi

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @brettcannon for commit a927f3d 🤖

The command will test the builders whose names match following regular expression: wasi

The builders matched are:

  • wasm32 WASI PR
  • wasm32-wasi PR

@brettcannon
Copy link
Member

I know @sobolevn is working on this overall, but this is failing on Python 3.11 even on non-pydebug builds, so fixing it quickly is important.

Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I was away for several days :)

Thanks for fixing this!

@kushaldas kushaldas merged commit 7218bac into python:main Nov 15, 2023
@miss-islington-app
Copy link

Thanks @kushaldas for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 15, 2023
(cherry picked from commit 7218bac)

Co-authored-by: Kushal Das <mail@kushaldas.in>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 15, 2023
(cherry picked from commit 7218bac)

Co-authored-by: Kushal Das <mail@kushaldas.in>
@bedevere-app
Copy link

bedevere-app bot commented Nov 15, 2023

GH-112131 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Nov 15, 2023
@bedevere-app
Copy link

bedevere-app bot commented Nov 15, 2023

GH-112132 is a backport of this pull request to the 3.11 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.11 only security fixes label Nov 15, 2023
@kushaldas kushaldas deleted the fix_111811 branch November 16, 2023 14:36
kushaldas added a commit that referenced this pull request Nov 16, 2023
gh-111811: Fix test_recursive_repr for WASI (GH-112130)
(cherry picked from commit 7218bac)

Co-authored-by: Kushal Das <mail@kushaldas.in>
kushaldas added a commit that referenced this pull request Nov 16, 2023
gh-111811: Fix test_recursive_repr for WASI (GH-112130)
(cherry picked from commit 7218bac)

Co-authored-by: Kushal Das <mail@kushaldas.in>
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants