Skip to content

bpo-22703: IDLE: Improve Code Context and Zoom Height menu labels #11214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Dec 22, 2018
Merged

bpo-22703: IDLE: Improve Code Context and Zoom Height menu labels #11214

merged 11 commits into from
Dec 22, 2018

Conversation

csabella
Copy link
Contributor

@csabella csabella commented Dec 18, 2018 •
edited by terryjreedy
Loading

The Code Context menu label now toggles between Show/Hide Code Context.
The Zoom Height menu now toggles between Zoom/Restore Height.
Zoom Height has moved from the Window menu to the Options menu.

https://bugs.python.org/issue22703

@csabella
bpo-22703: IDLE: Change menu text for Code Context.
bb81f61 
* Change text for Code Context to toggle between Show Code
  Context and Hide Code Context based on whether code context
  is active for the window.
* Move Zoom Height under Options menu.
@csabella
Add blurb
06ebd7d
@terryjreedy terryjreedy self-assigned this Dec 21, 2018
@terryjreedy terryjreedy mentioned this pull request Dec 21, 2018
Merged
@terryjreedy
Copy link
Member

terryjreedy commented Dec 21, 2018 •
edited
Loading

I deleted multiple comments about not being able to do any edit actions. It turn out to be a problem with github on current Firefox. I tried MS Edge and everything works.

terryjreedy
terryjreedy requested changes Dec 21, 2018
View reviewed changes
Copy link
Member

@terryjreedy terryjreedy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice. Consider changes. Otherwise, approve.

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@csabella
Alter menu label for Zoom Height.
f4115ec 
* Reverse Zoom Height and Code Context on options menu.
* Alter between Zoom/Restore Zoom Height menu label.
* Change indexing on menu item names.
@csabella
Copy link
Contributor Author

I have made the requested changes; please review again.

@bedevere-bot
Copy link

Thanks for making the requested changes!

@terryjreedy: please review the changes made to this pull request.

@terryjreedy terryjreedy changed the title bpo-22703: IDLE: Change menu text for Code Context whether it's open/closed bpo-22703: IDLE: Improve Code Context and Zoom Height menu labels Dec 22, 2018
@miss-islington
Copy link
Contributor

@csabella: Status check is done, and it's a failure ❌ .

@python python deleted a comment from miss-islington Dec 22, 2018
@python python deleted a comment from miss-islington Dec 22, 2018
@miss-islington
Copy link
Contributor

@csabella: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit c1b4b0f into python:master Dec 22, 2018
@miss-islington
Copy link
Contributor

Thanks @csabella for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-11286 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 22, 2018
@csabella @miss-islington
bpo-22703: IDLE: Improve Code Context and Zoom Height menu labels (py…
05d5fc8 
…thonGH-11214)

The Code Context menu label now toggles between Show/Hide Code Context.
 The Zoom Height menu now toggles between Zoom/Restore Height.
 Zoom Height has moved from the Window menu to the Options menu.

https://bugs.python.org/issue22703
(cherry picked from commit c1b4b0f)

Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>
miss-islington added a commit that referenced this pull request Dec 22, 2018
@miss-islington @csabella
bpo-22703: IDLE: Improve Code Context and Zoom Height menu labels (GH…
48a2069 
…-11214)

The Code Context menu label now toggles between Show/Hide Code Context.
 The Zoom Height menu now toggles between Zoom/Restore Height.
 Zoom Height has moved from the Window menu to the Options menu.

https://bugs.python.org/issue22703
(cherry picked from commit c1b4b0f)

Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>
@csabella csabella deleted the ccmenu branch December 22, 2018 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terryjreedy terryjreedy terryjreedy approved these changes

Assignees

@terryjreedy terryjreedy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@csabella @terryjreedy @bedevere-bot @miss-islington @the-knights-who-say-ni