-
-
Notifications
You must be signed in to change notification settings - Fork 31.8k
gh-112155: Run typing.py
doctests during tests
#112156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks!
Thanks @sobolevn for the PR, and @AlexWaygood for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
Sorry, @sobolevn and @AlexWaygood, I could not cleanly backport this to
|
Sorry, @sobolevn and @AlexWaygood, I could not cleanly backport this to
|
Will do manual backports later |
I just realised that there are no doctests in I'll just remove the "needs backport" labels. |
We now do, of course, following the changes made for #112194, so if you're still up for backporting this to 3.12 and 3.11, that would be great :-) |
Sure! |
GH-112230 is a backport of this pull request to the 3.12 branch. |
GH-112231 is a backport of this pull request to the 3.11 branch. |
After this change we can detect some hypothetical problems with
doctests
intyping.py
.After my change to some incorrect value doctest fails:
typing.py
contains two doctests that are not executed, ever #112155