Skip to content

GH-112152: Fix typo in typing.override docstring #112158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 16, 2023
Merged

GH-112152: Fix typo in typing.override docstring #112158

merged 1 commit into from
Nov 16, 2023

Conversation

Qua27
Copy link
Contributor

@Qua27 Qua27 commented Nov 16, 2023 •
edited by bedevere-app bot
Loading

Correcting a typo in typing module (closes #112152).

@ghost
Copy link

ghost commented Nov 16, 2023 •
edited by ghost
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-app

This comment was marked as resolved.

Sign in to view
@Qua27 Qua27 changed the title Correcting a typo in typing module [doc] Correct a typo in docstring for override from typing.py module (pythonGH-112152) Nov 16, 2023
@bedevere-app bedevere-app bot mentioned this pull request Nov 16, 2023
Closed
kushaldas
kushaldas approved these changes Nov 16, 2023
View reviewed changes
Copy link
Member

@kushaldas kushaldas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good.

@AlexWaygood AlexWaygood changed the title [doc] Correct a typo in docstring for override from typing.py module (pythonGH-112152) GH-112152: Fix typo in typing.override docstring Nov 16, 2023
@JelleZijlstra JelleZijlstra added the needs backport to 3.12 only security fixes label Nov 16, 2023
AlexWaygood
AlexWaygood approved these changes Nov 16, 2023
View reviewed changes
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@AlexWaygood AlexWaygood merged commit 12c7e9d into python:main Nov 16, 2023
@miss-islington-app
Copy link

Thanks @Qua27 for the PR, and @AlexWaygood for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 16, 2023
@Qua27 @miss-islington
pythonGH-112152: Fix typo in typing.override docstring (pythonGH-11…
baea8f3 
…2158)

(cherry picked from commit 12c7e9d)

Co-authored-by: Qua27 <92877777+Qua27@users.noreply.github.com>
@bedevere-app
Copy link

bedevere-app bot commented Nov 16, 2023

GH-112162 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Nov 16, 2023
AlexWaygood pushed a commit that referenced this pull request Nov 16, 2023
@miss-islington @Qua27
[3.12] GH-112152: Fix typo in typing.override docstring (GH-112158) (…
458a3c0 
…#112162)

GH-112152: Fix typo in `typing.override` docstring (GH-112158)
(cherry picked from commit 12c7e9d)

Co-authored-by: Qua27 <92877777+Qua27@users.noreply.github.com>
@Qua27 Qua27 deleted the patch-1 branch November 16, 2023 19:29
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@Qua27 @aisk
pythonGH-112152: Fix typo in typing.override docstring (python#112158)
035499b
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@Qua27 @Glyphack
pythonGH-112152: Fix typo in typing.override docstring (python#112158)
9ec4f3b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kushaldas kushaldas kushaldas approved these changes

@AlexWaygood AlexWaygood AlexWaygood approved these changes

@gvanrossum gvanrossum Awaiting requested review from gvanrossum

@JelleZijlstra JelleZijlstra Awaiting requested review from JelleZijlstra JelleZijlstra is a code owner

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Typo in docstring for override decorator from typing module.
4 participants
@Qua27 @kushaldas @AlexWaygood @JelleZijlstra