gh-108901: Deprecate inspect.getcallargs and slate it for removal
#112236
+35
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexWaygood
reviewed
Nov 18, 2023
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
terryjreedy
reviewed
Nov 18, 2023
Misc/NEWS.d/next/Library/2023-11-18-17-01-45.gh-issue-108901.T3p5ie.rst
Outdated
Show resolved
Hide resolved
terryjreedy
reviewed
Nov 18, 2023
terryjreedy
reviewed
Nov 18, 2023
|
@terryjreedy thank you! |
|
The added code looks sensible but I would want someone more knowledgeable to check and a manual test of the notice. |
This comment was marked as outdated.
This comment was marked as outdated.
itamaro
reviewed
Nov 20, 2023
Misc/NEWS.d/next/Library/2023-11-18-17-01-45.gh-issue-108901.T3p5ie.rst
Outdated
Show resolved
Hide resolved
Co-authored-by: Itamar Oren <itamarost@gmail.com>
AlexWaygood
reviewed
Nov 22, 2023
Misc/NEWS.d/next/Library/2023-11-18-17-01-45.gh-issue-108901.T3p5ie.rst
Outdated
Show resolved
Hide resolved
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
|
Ah, I see @hugovk asked for some changes in #108901 (comment) -- I'll hold off merging for now :) |
|
I also recently found this issue, which may have been forgotten here, and needs to be removed in the 3.16 if added in 3.14 |
|
@sobolevn: What's the status of your PR? |
|
I guess that I will have to start everything over in 3.15 :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since this function already has a modern alternative and was deprecated since 3.5, I've added a runtime warning for this function and slated it for removal in two versions (3.15) from now.
inspectmodule, deprecate old incorrect APIs #108901📚 Documentation preview 📚: https://cpython-previews--112236.org.readthedocs.build/