Skip to content

gh-79871: IDLE - Fix test_debugger bug and buildbot failures #112258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 19, 2023

Conversation

terryjreedy
Copy link
Member

Missing "requires('gui')" causes Tk() to fail when no gui. This caused CI Hypothesis test to fail,
but I did not understand message. Then buildbots failed.

IdbTest failed on draft Bdb replacement because so different.
Simplified version works on old and new.

Missing "requires('gui')" causes Tk() to fail when no gui.
IdbTest failed on draft Bdb replacement because so different.
@terryjreedy terryjreedy added type-bug An unexpected behavior, bug, or error topic-IDLE needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Nov 19, 2023
@terryjreedy terryjreedy self-assigned this Nov 19, 2023
@bedevere-app bedevere-app bot added awaiting core review tests Tests in the Lib/test dir labels Nov 19, 2023
@terryjreedy terryjreedy enabled auto-merge (squash) November 19, 2023 06:26
@terryjreedy terryjreedy merged commit 14fd86a into python:main Nov 19, 2023
@miss-islington-app
Copy link

Thanks @terryjreedy for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 19, 2023
Missing "requires('gui')" causes Tk() to fail when no gui.
This caused CI Hypothesis test to fail, but I did not understand
the its error message. Then buildbots failed.

IdbTest failed on draft Bdb replacement because so different.
Simplified version works on old and new.
(cherry picked from commit 14fd86a)

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
@bedevere-app
Copy link

bedevere-app bot commented Nov 19, 2023

GH-112259 is a backport of this pull request to the 3.12 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 19, 2023
Missing "requires('gui')" causes Tk() to fail when no gui.
This caused CI Hypothesis test to fail, but I did not understand
the its error message. Then buildbots failed.

IdbTest failed on draft Bdb replacement because so different.
Simplified version works on old and new.
(cherry picked from commit 14fd86a)

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Nov 19, 2023
@bedevere-app
Copy link

bedevere-app bot commented Nov 19, 2023

GH-112260 is a backport of this pull request to the 3.11 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.11 only security fixes label Nov 19, 2023
@terryjreedy terryjreedy deleted the dbugfix branch November 19, 2023 06:46
terryjreedy added a commit that referenced this pull request Nov 19, 2023
…112259)

IDLE: Fix test_debugger bug and buildbot failures (GH-112258)

Missing "requires('gui')" causes Tk() to fail when no gui.
This caused CI Hypothesis test to fail, but I did not understand
the its error message. Then buildbots failed.

IdbTest failed on draft Bdb replacement because so different.
Simplified version works on old and new.
(cherry picked from commit 14fd86a)

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
terryjreedy added a commit that referenced this pull request Nov 19, 2023
…112260)

IDLE: Fix test_debugger bug and buildbot failures (GH-112258)

Missing "requires('gui')" causes Tk() to fail when no gui.
This caused CI Hypothesis test to fail, but I did not understand
the its error message. Then buildbots failed.

IdbTest failed on draft Bdb replacement because so different.
Simplified version works on old and new.
(cherry picked from commit 14fd86a)

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
@terryjreedy
Copy link
Member Author

Fix for bug in #11451 for # #79871 and backports.

@terryjreedy terryjreedy changed the title IDLE: Fix test_debugger bug and buildbot failures gh-79871: IDLE - Fix test_debugger bug and buildbot failures Nov 19, 2023
@bedevere-app
Copy link

bedevere-app bot commented Nov 19, 2023

GH-112259 is a backport of this pull request to the 3.12 branch.

@bedevere-app
Copy link

bedevere-app bot commented Nov 19, 2023

GH-112260 is a backport of this pull request to the 3.11 branch.

aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
Missing "requires('gui')" causes Tk() to fail when no gui.
This caused CI Hypothesis test to fail, but I did not understand
the its error message. Then buildbots failed.

IdbTest failed on draft Bdb replacement because so different.
Simplified version works on old and new.
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
Missing "requires('gui')" causes Tk() to fail when no gui.
This caused CI Hypothesis test to fail, but I did not understand
the its error message. Then buildbots failed.

IdbTest failed on draft Bdb replacement because so different.
Simplified version works on old and new.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip issue skip news tests Tests in the Lib/test dir topic-IDLE type-bug An unexpected behavior, bug, or error
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant