gh-112281: Allow Union with unhashable Annotated metadata
#112283
Merged
+156
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faph
reviewed
Nov 20, 2023
AlexWaygood
reviewed
Nov 20, 2023
Misc/NEWS.d/next/Library/2023-11-20-16-15-44.gh-issue-112281.gH4EVk.rst
Outdated
Show resolved
Hide resolved
AlexWaygood
reviewed
Dec 2, 2023
AlexWaygood
reviewed
Dec 2, 2023
AlexWaygood
reviewed
Dec 2, 2023
AlexWaygood
reviewed
Dec 2, 2023
AlexWaygood
reviewed
Dec 2, 2023
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
AlexWaygood
reviewed
Dec 2, 2023
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
|
We just did 6 rounds of nitpicks :) |
AlexWaygood
approved these changes
Dec 2, 2023
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
|
I already approved this one :) |
JelleZijlstra
approved these changes
Mar 1, 2024
|
Thanks, and sorry for the wait! Do you think this should be backported? I lean yes because the old behavior feels like a bug. |
Yeah, agreed |
|
Thanks @sobolevn for the PR, and @AlexWaygood for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 1, 2024
…ythonGH-112283) (cherry picked from commit a7549b0) Co-authored-by: Nikita Sobolev <mail@sobolevn.me> Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
|
Sorry, @sobolevn and @AlexWaygood, I could not cleanly backport this to |
|
GH-116213 is a backport of this pull request to the 3.12 branch. |
AlexWaygood
added a commit
that referenced
this pull request
Mar 1, 2024
sobolevn
added a commit
to sobolevn/cpython
that referenced
this pull request
Mar 3, 2024
…adata (pythonGH-112283) (cherry picked from commit a7549b0) Co-authored-by: Nikita Sobolev <mail@sobolevn.me> Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
|
GH-116288 is a backport of this pull request to the 3.11 branch. |
AlexWaygood
added a commit
that referenced
this pull request
Mar 3, 2024
woodruffw
pushed a commit
to woodruffw-forks/cpython
that referenced
this pull request
Mar 4, 2024
…ython#112283) Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
adorilson
pushed a commit
to adorilson/cpython
that referenced
this pull request
Mar 25, 2024
…ython#112283) Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
diegorusso
pushed a commit
to diegorusso/cpython
that referenced
this pull request
Apr 17, 2024
…ython#112283) Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should not affect performance that much:
TypeErrorhappens on unhashable items (it should not affect code with only hashable parts)