Skip to content

gh-90102: Optimize io.FileIO.isatty() #112495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

gh-90102: Optimize io.FileIO.isatty() #112495

wants to merge 2 commits into from

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Nov 28, 2023 •
edited by bedevere-app bot
Loading

Only invoke the isatty() system call for character devices and cache the result.

@serhiy-storchaka
pythongh-90102: Optimize io.FileIO.isatty()
b1ef1fa 
Only invoke the isatty() system call for character devices and
cache the result.
@bedevere-app bedevere-app bot mentioned this pull request Nov 28, 2023
Closed
@serhiy-storchaka serhiy-storchaka added topic-IO performance Performance or resource usage labels Nov 28, 2023
colesbury
colesbury reviewed Nov 28, 2023
View reviewed changes
@serhiy-storchaka
Copy link
Member Author

It does not work, because the file descriptor can be reassigned from tty to non-tty and vice versa. The result of isatty() can not be cached.

@serhiy-storchaka serhiy-storchaka deleted the cache-fileio-isatty branch December 14, 2023 17:30
@cmaloney cmaloney mentioned this pull request Jul 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colesbury colesbury colesbury left review comments

Assignees
No one assigned
Labels
awaiting core review performance Performance or resource usage topic-IO
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@serhiy-storchaka @colesbury