Skip to content

Conversation

gaogaotiantian
Copy link
Member

@gaogaotiantian gaogaotiantian commented Nov 29, 2023

@corona10 corona10 self-assigned this Nov 29, 2023
@corona10
Copy link
Member

corona10 commented Nov 29, 2023

I will think a little bit more about side effects from this change :)
Please give me time to this weekend.

@gaogaotiantian
Copy link
Member Author

No problem.

The readline/editline stuff in readline is a bit twisted. I believe at least as of now we never use the real editline.h. We use either readline/readline.h, which could be either from the real GNU readline or the "emulated" Mac libedit, or editline/readline.h, which is the compatible header from editline - it could be libedit-dev or some libedit om Mac.

WITH_EDITLINE does not make the situation clearer.

@corona10 corona10 merged commit e7e1116 into python:main Dec 5, 2023
@gaogaotiantian gaogaotiantian deleted the readline-editline branch December 5, 2023 21:20
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants