gh-105912: document gotcha with using os.fork on macOS #112871
Merged
+21
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using ``fork(2)`` on macOS when also using higher-level system APIs in the parent proces can crash on macOS because those system APIs are not written to handle this usage pattern. There's nothing we can do about this other than documenting the problem.
|
I'm not entirely happy about using "unsafe" as the description, but I'm not sure about a better alternative that doesn't use a lot more text. This also replicates part of the text in the |
willingc
approved these changes
Dec 13, 2023
There was a problem hiding this comment.
I agree with you @ronaldoussoren about not being completely happy with "unsafe". I can't think of a way of succinctly stating this without talking about parent and child processes on macOS.
Going to merge since this at least flags the gotcha.
willingc
approved these changes
Dec 13, 2023
serhiy-storchaka
approved these changes
Dec 14, 2023
|
Thanks @ronaldoussoren for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 14, 2023
…H-112871) * pythongh-105912: document gotcha with using os.fork on macOS Using ``fork(2)`` on macOS when also using higher-level system APIs in the parent proces can crash on macOS because those system APIs are not written to handle this usage pattern. There's nothing we can do about this other than documenting the problem. (cherry picked from commit 22511f7) Co-authored-by: Ronald Oussoren <ronaldoussoren@mac.com> Co-authored-by: Carol Willing <carolcode@willingconsulting.com>
|
GH-113133 is a backport of this pull request to the 3.12 branch. |
|
Sorry, @ronaldoussoren, I could not cleanly backport this to |
|
GH-113135 is a backport of this pull request to the 3.11 branch. |
corona10
pushed a commit
to corona10/cpython
that referenced
this pull request
Dec 15, 2023
…112871) * pythongh-105912: document gotcha with using os.fork on macOS Using ``fork(2)`` on macOS when also using higher-level system APIs in the parent proces can crash on macOS because those system APIs are not written to handle this usage pattern. There's nothing we can do about this other than documenting the problem. Co-authored-by: Carol Willing <carolcode@willingconsulting.com>
ronaldoussoren
added a commit
that referenced
this pull request
Dec 16, 2023
) (#113133) gh-105912: document gotcha with using os.fork on macOS (GH-112871) * gh-105912: document gotcha with using os.fork on macOS Using ``fork(2)`` on macOS when also using higher-level system APIs in the parent proces can crash on macOS because those system APIs are not written to handle this usage pattern. There's nothing we can do about this other than documenting the problem. (cherry picked from commit 22511f7) Co-authored-by: Ronald Oussoren <ronaldoussoren@mac.com> Co-authored-by: Carol Willing <carolcode@willingconsulting.com>
ronaldoussoren
added a commit
that referenced
this pull request
Dec 16, 2023
) (#113135) * gh-105912: document gotcha with using os.fork on macOS Using ``fork(2)`` on macOS when also using higher-level system APIs in the parent proces can crash on macOS because those system APIs are not written to handle this usage pattern. There's nothing we can do about this other than documenting the problem. (cherry picked from commit 22511f7) Co-authored-by: Carol Willing <carolcode@willingconsulting.com>
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
…112871) * pythongh-105912: document gotcha with using os.fork on macOS Using ``fork(2)`` on macOS when also using higher-level system APIs in the parent proces can crash on macOS because those system APIs are not written to handle this usage pattern. There's nothing we can do about this other than documenting the problem. Co-authored-by: Carol Willing <carolcode@willingconsulting.com>
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
…112871) * pythongh-105912: document gotcha with using os.fork on macOS Using ``fork(2)`` on macOS when also using higher-level system APIs in the parent proces can crash on macOS because those system APIs are not written to handle this usage pattern. There's nothing we can do about this other than documenting the problem. Co-authored-by: Carol Willing <carolcode@willingconsulting.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
fork(2)on macOS when also using higher-level system APIs in the parent proces can crash on macOS because those system APIs are not written to handle this usage pattern.There's nothing we can do about this other than documenting the problem.
📚 Documentation preview 📚: https://cpython-previews--112871.org.readthedocs.build/