Skip to content

gh-86918: Fix file descriptor leaking in multiprocessing.Queue #112900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

gh-86918: Fix file descriptor leaking in multiprocessing.Queue #112900

wants to merge 3 commits into from
+6 −0

Conversation

LorewalkerZhou
Copy link

@LorewalkerZhou LorewalkerZhou commented Dec 9, 2023 •
edited by bedevere-app bot
Loading

If don't put data in multiprocessing.Queue and directly close the queue, queue._reader and queue._writer wouldn't be closd.

Python 3.13.0a2+ (heads/fix-issue-86918:14203efdc5, Dec  9 2023, 22:01:44) [Clang 15.0.0 (clang-1500.0.40.1)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import multiprocessing
>>> q = multiprocessing.Queue()
>>> q.close()
>>> q.join_thread()
>>> q._reader.closed
True
>>> q._writer.closed
True
>>>

@ghost
Copy link

ghost commented Dec 9, 2023 •
edited by ghost
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-app
Copy link

bedevere-app bot commented Dec 9, 2023

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@bedevere-app bedevere-app bot mentioned this pull request Dec 9, 2023
Open
@rhettinger rhettinger removed their request for review December 10, 2023 21:51
@python-cla-bot
Copy link

The following commit authors need to sign the Contributor License Agreement:

CLA signed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
awaiting review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@LorewalkerZhou