Skip to content

gh-112559: Avoid unnecessary conversion attempts to enum_klass in signal.py. #113040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 24, 2023
Merged

gh-112559: Avoid unnecessary conversion attempts to enum_klass in signal.py. #113040

merged 3 commits into from
Dec 24, 2023

Conversation

yilei
Copy link
Contributor

@yilei yilei commented Dec 13, 2023 •
edited
Loading

@bedevere-app bedevere-app bot mentioned this pull request Dec 13, 2023
Closed
@yilei yilei marked this pull request as ready for review December 13, 2023 04:45
@hauntsaninja hauntsaninja added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Dec 13, 2023
@hauntsaninja
Copy link
Contributor

Added backports since this can cause regressions like jax-ml/jax#18743

gvanrossum
gvanrossum approved these changes Dec 24, 2023
View reviewed changes
Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! Sorry for the long wait time. I'm finally clearing some of my backlog. I'll merge it now and kick the backports.

@gvanrossum gvanrossum merged commit 050783c into python:main Dec 24, 2023
@miss-islington-app
Copy link

Thanks @yilei for the PR, and @gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

@bedevere-app
Copy link

bedevere-app bot commented Dec 24, 2023

GH-113443 is a backport of this pull request to the 3.12 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 24, 2023
@yilei @miss-islington
pythongh-112559: Avoid unnecessary conversion attempts to enum_klass …
2055f4f 
…in signal.py (pythonGH-113040)

(cherry picked from commit 050783c)

Co-authored-by: Yilei Yang <yileiyang@google.com>
@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Dec 24, 2023
@bedevere-app
Copy link

bedevere-app bot commented Dec 24, 2023

GH-113444 is a backport of this pull request to the 3.11 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 24, 2023
@yilei @miss-islington
pythongh-112559: Avoid unnecessary conversion attempts to enum_klass …
8801786 
…in signal.py (pythonGH-113040)

(cherry picked from commit 050783c)

Co-authored-by: Yilei Yang <yileiyang@google.com>
@bedevere-app bedevere-app bot removed the needs backport to 3.11 only security fixes label Dec 24, 2023
gvanrossum pushed a commit that referenced this pull request Dec 24, 2023
@miss-islington @yilei
[3.11] gh-112559: Avoid unnecessary conversion attempts to enum_klass…
b60bddb 
… in signal.py (GH-113040) (#113444)

gh-112559: Avoid unnecessary conversion attempts to enum_klass in signal.py (GH-113040)
(cherry picked from commit 050783c)

Co-authored-by: Yilei Yang <yileiyang@google.com>
gvanrossum pushed a commit that referenced this pull request Dec 24, 2023
@miss-islington @yilei
[3.12] gh-112559: Avoid unnecessary conversion attempts to enum_klass…
7f2ebc8 
… in signal.py (GH-113040) (#113443)

(cherry picked from commit 050783c)

Co-authored-by: Yilei Yang <yileiyang@google.com>
@yilei yilei deleted the signal branch December 24, 2023 02:12
ryan-duve pushed a commit to ryan-duve/cpython that referenced this pull request Dec 26, 2023
@yilei @ryan-duve
pythongh-112559: Avoid unnecessary conversion attempts to enum_klass …
2e10d7e 
…in signal.py (python#113040)
kulikjak pushed a commit to kulikjak/cpython that referenced this pull request Jan 22, 2024
@yilei @kulikjak
pythongh-112559: Avoid unnecessary conversion attempts to enum_klass …
c64b925 
…in signal.py (python#113040)
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@yilei @aisk
pythongh-112559: Avoid unnecessary conversion attempts to enum_klass …
4e623af 
…in signal.py (python#113040)
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@yilei @Glyphack
pythongh-112559: Avoid unnecessary conversion attempts to enum_klass …
3fdefe9 
…in signal.py (python#113040)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

@kumaraditya303 kumaraditya303 Awaiting requested review from kumaraditya303 kumaraditya303 is a code owner

@willingc willingc Awaiting requested review from willingc willingc is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yilei @hauntsaninja @gvanrossum