Skip to content

gh-110824 Fix test_sysconfig.test_library on framework builds. #113298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jan 2, 2024
Merged

gh-110824 Fix test_sysconfig.test_library on framework builds. #113298

Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
4c77a0c
fix check for LDLIBRARY on framework builds
smontanaro Dec 19, 2023
0f9f2b9
better structure, suggested by Ned Deily
smontanaro Dec 19, 2023
1242405
accommodate --with-framework-name
smontanaro Dec 20, 2023
e051bfa
Merge branch 'python:main' into issue110824
smontanaro Dec 20, 2023
a64e09e
Merge branch 'main' into issue110824
smontanaro Dec 20, 2023
65f0ec0
Merge branch 'python:main' into issue110824
smontanaro Dec 21, 2023
a727550
patch requested by Ronald Oussoren to fix treatment of sys._framework
smontanaro Dec 21, 2023
4f53021
Merge branch 'main' into issue110824
smontanaro Dec 21, 2023
db3fb1f
Merge branch 'python:main' into issue110824
smontanaro Dec 22, 2023
d33b2f4
Merge branch 'main' into issue110824
ned-deily Jan 2, 2024
97a6a97
Temporarily skip test_library for macOS framework builds until the is…
ned-deily Jan 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions Lib/test/test_sysconfig.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ def setUp(self):
self.name = os.name
self.platform = sys.platform
self.version = sys.version
self._framework = sys._framework
self.sep = os.sep
self.join = os.path.join
self.isabs = os.path.isabs
Expand All @@ -66,6 +67,7 @@ def tearDown(self):
os.name = self.name
sys.platform = self.platform
sys.version = self.version
sys._framework = self._framework
os.sep = self.sep
os.path.join = self.join
os.path.isabs = self.isabs
Expand Down Expand Up @@ -139,7 +141,7 @@ def test_get_preferred_schemes(self):
# Mac, framework build.
os.name = 'posix'
sys.platform = 'darwin'
sys._framework = True
sys._framework = "MyPython"
self.assertIsInstance(schemes, dict)
self.assertEqual(set(schemes), expected_schemes)

Expand Down Expand Up @@ -413,7 +415,10 @@ def test_library(self):
else:
self.assertTrue(library.startswith(f'libpython{major}.{minor}'))
self.assertTrue(library.endswith('.a'))
self.assertTrue(ldlibrary.startswith(f'libpython{major}.{minor}'))
if sys.platform == 'darwin' and sys._framework:
self.skipTest('gh-110824: skip LDLIBRARY test for framework build')
else:
self.assertTrue(ldlibrary.startswith(f'libpython{major}.{minor}'))

@unittest.skipUnless(sys.platform == "darwin", "test only relevant on MacOSX")
@requires_subprocess()
Expand Down