gh-113437: Update documentation about PyUnicode_AsWideChar() function #113455
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugovk
reviewed
Dec 25, 2023
Doc/c-api/unicode.rst
Outdated
| @@ -854,7 +854,8 @@ wchar_t Support | |||
| Copy the Unicode object contents into the :c:type:`wchar_t` buffer *wstr*. At most | |||
| *size* :c:type:`wchar_t` characters are copied (excluding a possibly trailing | |||
| null termination character). Return the number of :c:type:`wchar_t` characters | |||
| copied or ``-1`` in case of an error. Note that the resulting :c:expr:`wchar_t*` | |||
| copied or ``-1`` in case of an error. When :c:type:`wchar_t` buffer *wstr* is NULL, return | |||
There was a problem hiding this comment.
Suggested change
| copied or ``-1`` in case of an error. When :c:type:`wchar_t` buffer *wstr* is NULL, return | |
| copied or ``-1`` in case of an error. When :c:type:`wchar_t` buffer *wstr* is ``NULL``, return |
Doc/c-api/unicode.rst
Outdated
| @@ -854,7 +854,8 @@ wchar_t Support | |||
| Copy the Unicode object contents into the :c:type:`wchar_t` buffer *wstr*. At most | |||
| *size* :c:type:`wchar_t` characters are copied (excluding a possibly trailing | |||
| null termination character). Return the number of :c:type:`wchar_t` characters | |||
| copied or ``-1`` in case of an error. Note that the resulting :c:expr:`wchar_t*` | |||
| copied or ``-1`` in case of an error. When :c:type:`wchar_t` buffer *wstr* is NULL, return | |||
| the length of the Unicode object plus one.Note that the resulting :c:expr:`wchar_t*` | |||
There was a problem hiding this comment.
Suggested change
| the length of the Unicode object plus one.Note that the resulting :c:expr:`wchar_t*` | |
| the length of the Unicode object plus one. Note that the resulting :c:expr:`wchar_t*` |
encukou
reviewed
Feb 2, 2024
|
Thanks @qqwqqw689 for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12. |
|
Thanks @qqwqqw689 for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 13, 2024
…nction (pythonGH-113455) (cherry picked from commit 5719aa2) Co-authored-by: qqwqqw689 <114795525+qqwqqw689@users.noreply.github.com>
|
GH-115407 is a backport of this pull request to the 3.12 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 13, 2024
…nction (pythonGH-113455) (cherry picked from commit 5719aa2) Co-authored-by: qqwqqw689 <114795525+qqwqqw689@users.noreply.github.com>
|
GH-115408 is a backport of this pull request to the 3.11 branch. |
encukou
pushed a commit
that referenced
this pull request
Feb 14, 2024
encukou
pushed a commit
that referenced
this pull request
Feb 14, 2024
fsc-eriker
pushed a commit
to fsc-eriker/cpython
that referenced
this pull request
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update documentation about PyUnicode_AsWideChar() function.
📚 Documentation preview 📚: https://cpython-previews--113455.org.readthedocs.build/