gh-113924: Allow pre-compressed data to be written into a zip via zipfile.
#113925
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Intended to be used when constructing zip files via a system that can parallelize and cache all actions including compressing individual input file contents so that you can distribute actions & avoid recomputation.
merwok
reviewed
Oct 20, 2024
Comment on lines
+1016
to
+1017
| f"Bad CRC-32 for file {self.name!r} expected " | ||
| f"{hex(self._expected_crc)} != {hex(self._running_crc)}") |
There was a problem hiding this comment.
Did you keep the beginning of the error message identical to keep compatibility?
If not, then it could be easier to read if it was like bad crc32 {got value} for file {name}, expected {expected value}. For now it’s slightly unpleasant to read about bad value, expected, expected, bad.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intended to be used when constructing zip files via a system that can parallelize and cache all actions including compressing individual input file contents so that you can distribute actions & avoid recomputation.
This also adds the missing ability to pass in pre-constructed
ZipInfoto thewritemethod as pre-compressed data needs its original file_size and uncompressed data CRC to also have been pre-computed.zipfilemodule. #113924