Skip to content

[3.11] gh-113358 Fix rendering tracebacks with exceptions with a broken __getattr__ : Normalize exception #114379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 21, 2024
Merged

[3.11] gh-113358 Fix rendering tracebacks with exceptions with a broken __getattr__ : Normalize exception #114379

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fe32493
[3.11] Normalize exception
perrinjerome Jan 21, 2024
f0a7099
Merge branch '3.11' into backport-f0185e3-3.11
iritkatriel Jan 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Python/pythonrun.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1206,6 +1206,7 @@ get_exception_notes(struct exception_print_context *ctx, PyObject *value, PyObje
if (_PyObject_LookupAttr(value, &_Py_ID(__notes__), notes) < 0) {
PyObject *type, *errvalue, *tback;
PyErr_Fetch(&type, &errvalue, &tback);
PyErr_NormalizeException(&type, &errvalue, &tback);
note = PyUnicode_FromFormat("Ignored error getting __notes__: %R", errvalue);
Py_XDECREF(type);
Py_XDECREF(errvalue);
Expand Down