gh-114100: Replace print in test_pty with a simple expression
#114645
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -292,7 +292,7 @@ def test_master_read(self): | |||
| self.assertEqual(data, b"") | |||
|
|
|||
| def test_spawn_doesnt_hang(self): | |||
| pty.spawn([sys.executable, '-c', 'print("hi there")']) | |||
| pty.spawn([sys.executable, '-c', '1 + 1']) | |||
There was a problem hiding this comment.
It may be a part of the manual testing. pty.spawn() runs subprocess and copy its stdout to this process stdout (fileno 1). The change that added this test ensured that pty.spawn() returns when reading from child returns empty bytes. But this test can implicitly test that pty.spawn() works at all and does not return before copying all child's output to stdout.
I try to automate this in #114647.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From name of test (
test_spawn_doesnt_hang) I can assume that purpose of this test - check that spawn doesn't hang, so I had chosen this approach.Another approach may be the same as in #114565.
test_ptyprints unnecessary information #114100